-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nekoray: init at 3.26 #300794
nekoray: init at 3.26 #300794
Conversation
Updated the PR to include the geodata files too. |
Result of 1 package built:
Tested
Earlier I was using a patched nekoray binary as a workaround, it has similar problem now, but used to work before (around December 2023). Looks like some dependencies were updated, causing incompatibilities. But it is a minor feature, nothing critical. Thank you for packaging this one! |
Thanks for your contribution, I'll test it tomorrow. Also perhaps we need some capability wrappers or services for this, which can be done in another PR. |
Would anyone here like to co-maintain this package? I'm not actually someone who uses this program, I just like packaging stuff, so I don't really know how to use the program. Because of this I'm probably not qualified to create a service for this ATM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested basic functionality. Looks good.
@TomaSajt I will maintain the functionality of this package in the future. I will add myself to the maintainer in the next update. |
@ofborg eval |
@ofborg build |
Description of changes
Closes #244451
I successfully built the
nekoray
package, and using 2 extra derivations withbuildGoModule
, I added the required*_core
files as well.The fetching is a bit weird, because I didn't want to deal with upstream's WEIRD way of fetching other repositories.
This needs some testing as I haven't got any experience with this program.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.