Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: 4.9.3 -> 5.0.0 #299302

Closed
wants to merge 2 commits into from
Closed

podman: 4.9.3 -> 5.0.0 #299302

wants to merge 2 commits into from

Conversation

zaphar
Copy link
Contributor

@zaphar zaphar commented Mar 26, 2024

Update Podman to v5.0.0

Release notes: https://github.com/containers/podman/releases/tag/v5.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zaphar
Copy link
Contributor Author

zaphar commented Mar 26, 2024

This should work everywhere but I've only been able to test on an M1 macbook.
cc: @marsam

@DontEatOreo
Copy link
Member

DontEatOreo commented Mar 26, 2024

You should rebase your commit to be

podman: 4.9.3 -> 5.0.0

Also please split the patch changes to be separate commit and change the PR title

Check out: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

@zaphar
Copy link
Contributor Author

zaphar commented Mar 26, 2024

@DontEatOreo , done.

@DontEatOreo
Copy link
Member

DontEatOreo commented Mar 27, 2024

The patch commit should have a different title, something like:

podman: remove mac helper message

Also please update the PR title to podman: 4.9.3 -> 5.0.0

@zaphar zaphar changed the title Update Podman to v5.0.0 podman: 4.9.3 -> 5.0.0 Mar 27, 2024
@zaphar
Copy link
Contributor Author

zaphar commented Mar 27, 2024

Done.

@sdht0
Copy link
Contributor

sdht0 commented Apr 2, 2024

https://github.com/containers/podman/releases/tag/v5.0.1 is now out

@the-sun-will-rise-tomorrow
Copy link
Contributor

Hi!

  • Podman switched to passt for user level networking (passt: init at 2023_11_10 #265409). Is it not needed here?

  • I needed to patch the paths in vendor/github.com/containers/common/pkg/config/default.go. Without that patch, it tried to run executables in /usr/bin, ignoring the PATH built by the nixpkgs wrapper. Have you run into this?

Reference: #301553

@zaphar
Copy link
Contributor Author

zaphar commented Apr 4, 2024

@WxNzEMof I didn't run into those issues yet. But I wouldn't be surprised if they were needed. I haven't had the time to come back to this for a bit. If someone else want's to take over I'll not be offended. Otherwise it can wait till I have time again.

@DontEatOreo
Copy link
Member

Since v5.0.1 is out, could you amend the last commit with the new version and update the PR title?

@SuperSandro2000
Copy link
Member

Closing in favor of #301553 because it has a more complete approach to all features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants