-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman: 4.9.3 -> 5.0.0 #299302
podman: 4.9.3 -> 5.0.0 #299302
Conversation
This should work everywhere but I've only been able to test on an M1 macbook. |
You should rebase your commit to be
Also please split the patch changes to be separate commit and change the PR title Check out: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions |
@DontEatOreo , done. |
The patch commit should have a different title, something like:
Also please update the PR title to |
Update podman sources to v5.0.0 tag. Release notes: https://github.com/containers/podman/releases/tag/v5.0.0
Done. |
Hi!
Reference: #301553 |
@WxNzEMof I didn't run into those issues yet. But I wouldn't be surprised if they were needed. I haven't had the time to come back to this for a bit. If someone else want's to take over I'll not be offended. Otherwise it can wait till I have time again. |
Since v5.0.1 is out, could you amend the last commit with the new version and update the PR title? |
Closing in favor of #301553 because it has a more complete approach to all features |
Update Podman to v5.0.0
Release notes: https://github.com/containers/podman/releases/tag/v5.0.0
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.