Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itsycal: init at 0.15.3 #299257

Closed
wants to merge 1 commit into from
Closed

itsycal: init at 0.15.3 #299257

wants to merge 1 commit into from

Conversation

DontEatOreo
Copy link
Member

Description of changes

A small macOS calendar program

GitHub Repo: https://github.com/sfsam/Itsycal

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 26, 2024
@DontEatOreo DontEatOreo requested a review from stepbrobd March 26, 2024 18:39
Copy link
Member

@stepbrobd stepbrobd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I'm not sure if you are aware of #293498, the packaging process should be way easier after merging. I suggest keep track with #293498 and change the current stdenvNoCC.mkDerivation approach to darwin.installBinaryPackage after it merges.

version = "0.15.3";

src = fetchurl {
url = "https://web.archive.org/web/20240326164201/https://itsycal.s3.amazonaws.com/Itsycal.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have versioned download links:

https://itsycal.s3.amazonaws.com/Itsycal-<MAJOR.MINOR.PATCH>.zip

Source:
[1] https://formulae.brew.sh/cask/itsycal#default
[2] https://formulae.brew.sh/api/cask/itsycal.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

meta = {
description = "Itsycal is a tiny menu bar calendar";
homepage = "https://www.mowglii.com/itsycal/";
license = lib.licenses.free;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any explicit licensing statement on their website, probably we should use unfree here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're looking at the old commit as it's free on commit 52269f864923947582e230028dbec096cafdee78 although I will change to mit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DontEatOreo
Copy link
Member Author

Looking good!

I'm not sure if you are aware of #293498, the packaging process should be way easier after merging. I suggest keep track with #293498 and change the current stdenvNoCC.mkDerivation approach to darwin.installBinaryPackage after it merges.

Thanks for notifying me about this I wasn't aware! I will keep track.

@DontEatOreo DontEatOreo requested a review from stepbrobd March 26, 2024 19:15
@DontEatOreo DontEatOreo deleted the itsycal branch March 26, 2024 19:42
@DontEatOreo DontEatOreo mentioned this pull request Mar 26, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants