Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mousecape: init at 1813 #299032

Merged
merged 1 commit into from
Mar 26, 2024
Merged

mousecape: init at 1813 #299032

merged 1 commit into from
Mar 26, 2024

Conversation

DontEatOreo
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DontEatOreo DontEatOreo self-assigned this Mar 25, 2024
@DontEatOreo DontEatOreo requested a review from emilytrau March 25, 2024 22:23
@DontEatOreo DontEatOreo removed their assignment Mar 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 25, 2024
pkgs/os-specific/darwin/mousecape/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/mousecape/default.nix Outdated Show resolved Hide resolved
@DontEatOreo DontEatOreo requested a review from drupol March 26, 2024 10:09
@drupol drupol merged commit 71df962 into NixOS:master Mar 26, 2024
18 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@ghost
Copy link

ghost commented Mar 27, 2024

this package doesn't conform to https://github.com/NixOS/nixpkgs/tree/master/pkgs#category-hierarchy regarding it's location. it needs to be moved to by-name. the os-specific area contains mostly system level libraries and apps and while there is no guidance to what goes here in the upper level pkg readme the docs are clear that new apps go under by-name.

@DontEatOreo DontEatOreo mentioned this pull request Mar 27, 2024
13 tasks
DontEatOreo added a commit to DontEatOreo/nixpkgs that referenced this pull request Mar 27, 2024
- Previously package resided in darwin/mousecape due to confusion, this
  breaks the pkgs category hierarchy as mentioned by
  NixOS#299032 (comment)
- Also switched to using fetchzip
- Fixed maintainer name
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
- Previously package resided in darwin/mousecape due to confusion, this
  breaks the pkgs category hierarchy as mentioned by
  #299032 (comment)
- Also switched to using fetchzip
- Fixed maintainer name

(cherry picked from commit ba1834b)
zeme-wana pushed a commit to input-output-hk/nixpkgs that referenced this pull request May 8, 2024
- Previously package resided in darwin/mousecape due to confusion, this
  breaks the pkgs category hierarchy as mentioned by
  NixOS#299032 (comment)
- Also switched to using fetchzip
- Fixed maintainer name

(cherry picked from commit ba1834b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants