Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahk_x11: init at 1.0.4 #298173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ahk_x11: init at 1.0.4 #298173

wants to merge 1 commit into from

Conversation

UlyssesZh
Copy link
Contributor

@UlyssesZh UlyssesZh commented Mar 22, 2024

Description of changes

Adds package AHK_X11, an AutoHotkey implementation for Linux.

Closes #279323. Closes #297972 (this PR contains the commit in that PR) (already merged). CC @AndersonTorres.

It reports command not found for file command if your PATH does not contain that command. This error does not affect normal usage. I could have fixed by adding file as a dependency, but this is actually a non-fatal upstream bug (phil294/AHK_X11#75), so I left it like this (Fixed in upstream).

AHK_X11 from this package does not have functionality of compiling scripts into portable executable. The implementation of that compilation feature is simply to concatenate the binary and the script to form an executable file, but executable files in NixOS are not executable in other systems. I was thinking packaging a ahk_x11-bin package for that demand, but I didn't do that because the executable cannot run in the environment where it was built (even with steam-run due to the requirement of libnotify).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 22, 2024
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
@UlyssesZh UlyssesZh changed the title ahk_x11: init at 1.0.4-b76359f ahk_x11: init at 1.0.3-unstable-2024-03-22 Mar 23, 2024
@UlyssesZh UlyssesZh changed the title ahk_x11: init at 1.0.3-unstable-2024-03-22 ahk_x11: init at 1.0.3-unstable-2024-03-30 Mar 30, 2024
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bug catch!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 30, 2024
@UlyssesZh
Copy link
Contributor Author

The new push just now utilized the copyShardDeps flag introduced in #289266 (merged days ago).

#305484 may change the situation a bit, too, because this package is using gi-crystal. In #305484 (comment), I was hoping we can have a better way of packaging Crystal packages that use gi-crystal.

CC @sund3RRR.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 27, 2024
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ah/ahk_x11/package.nix Outdated Show resolved Hide resolved
@UlyssesZh UlyssesZh changed the title ahk_x11: init at 1.0.3-unstable-2024-03-30 ahk_x11: init at 1.0.4 Nov 14, 2024
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 14, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: AHK_X11
5 participants