qlcplus: 4.12.3 -> 4.13.0 #297272
Merged
qlcplus: 4.12.3 -> 4.13.0 #297272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
|
Please amend your fixup commit into original commit. |
Aleksanaa
reviewed
Apr 1, 2024
|
@Aleksanaa Thank you for the review, I have applied the suggestion (also modified the inputs of the derivation accordingly), squashed the fixup and force pushed. ✅ |
Aleksanaa
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/mcallegari/qlcplus/blob/master/debian/changelog
The previously included patch is part of the release since 4.12.4, so it doesn't need to be specified separately anymore.
Also, as far as I can tell, unless it is specifically aimed at the future 5.0.0 release, issue #187049 can be closed, as this package already exists.
Edit 1: I must've messed something up, as I have built this yesterday on my desktop, but it doesn't currently build on my laptop. 🤔 I'll convert it to a draft while I figure it out.
Edit 2: Well, it seems like I have somehow built an earlier version by mistake yesterday... Sorry for the noise, I'll try to clean this up!
Edit 3: After adding
qtserialportas a build input, it seems to work for me now.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.