Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kuro: bump electron version and do cleanup #296483

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Mar 16, 2024

Description of changes

Tracking issue: #295770

This PR bumps the electron version used by kuro to electron_28 and does some minor cleanup.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from LostAttractor March 16, 2024 19:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 16, 2024
@yu-re-ka
Copy link
Contributor

Again, seeing the unpinning electron critically. Practically, every electron app needs regular work for updating & testing with new electron versions. That's the most important thing really.
Do you want to add yourself into the maintainers maybe?

@TomaSajt TomaSajt force-pushed the kuro branch 2 times, most recently from 790ddd8 to f212757 Compare March 17, 2024 08:39
@TomaSajt TomaSajt changed the title kuro: unlock electron and do cleanup kuro: bump electron and do cleanup Mar 17, 2024
@TomaSajt TomaSajt changed the title kuro: bump electron and do cleanup kuro: bump electron version and do cleanup Mar 17, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2024
@yu-re-ka yu-re-ka merged commit 5c0f7fb into NixOS:master Mar 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants