Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s: fix update script for 1.26, 1.27 #296155

Merged
merged 5 commits into from
Mar 17, 2024
Merged

k3s: fix update script for 1.26, 1.27 #296155

merged 5 commits into from
Mar 17, 2024

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Mar 15, 2024 •
edited
Loading

k3s: fix update script for 1.26, 1.27
k3s: pin go version to k3s go.mod
k3s: remove restriction on runtime checking of golang version
k3s_1_27: 1.27.9+k3s1 -> 1.27.11+k3s1
k3s_1_26: 1.26.9+k3s1 -> 1.26.14+k3s1

In nixpkgs, to update:

pkgs/applications/networking/cluster/k3s/update-script.sh "26"
pkgs/applications/networking/cluster/k3s/update-script.sh "27"

To test build:

nix build .#k3s_1_27.passthru.tests.{single-node,multi-node,etcd}
nix build .#k3s_1_26.passthru.tests.{single-node,multi-node,etcd}

@superherointj
k3s: fix update script for 1.26, 1.27 versions
717a342 
Fixes previous code not listing all tag versions and failing to pick the
latest version.
@superherointj
k3s: pin go version to k3s go.mod
551ef9c 
- Go 1.20 is being removed. NixOS#295077
- K3s should use go compiler version from go.mod file for each version.
@superherointj superherointj requested a review from euank March 15, 2024 13:52
@superherointj superherointj mentioned this pull request Mar 15, 2024
Merged
16 tasks
@superherointj superherointj marked this pull request as draft March 15, 2024 13:56
@superherointj superherointj force-pushed the k3s-fix-update-script-for-1.26-1.27 branch from 0bb5e3b to fff5fb5 Compare March 15, 2024 13:57
@superherointj superherointj force-pushed the k3s-fix-update-script-for-1.26-1.27 branch from fff5fb5 to 403e92d Compare March 15, 2024 14:03
@superherointj superherointj requested a review from yajo March 15, 2024 14:04
@superherointj superherointj marked this pull request as ready for review March 15, 2024 14:10
@superherointj
Copy link
Contributor Author

@ofborg build k3s_1_27.passthru.tests.single-node k3s_1_27.passthru.tests.multi-node k3s_1_27.passthru.tests.etcd k3s_1_26.passthru.tests.single-node k3s_1_26.passthru.tests.multi-node k3s_1_26.passthru.tests.etcd

SuperSandro2000
SuperSandro2000 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from Mic92 March 15, 2024 14:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 15, 2024
@superherointj superherointj merged commit 56614a4 into NixOS:master Mar 17, 2024
33 checks passed
@superherointj superherointj deleted the k3s-fix-update-script-for-1.26-1.27 branch March 17, 2024 16:30
@superherointj superherointj added the 6.topic: k3s Kubernates distribution (https://k3s.io/) label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@euank euank Awaiting requested review from euank

@yajo yajo Awaiting requested review from yajo

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: k3s Kubernates distribution (https://k3s.io/) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superherointj @SuperSandro2000