Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obinskit: remove #296146

Merged
merged 1 commit into from
Mar 20, 2024
Merged

obinskit: remove #296146

merged 1 commit into from
Mar 20, 2024

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Mar 15, 2024 •
edited
Loading

Description of changes

Related: #295770

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yu-re-ka yu-re-ka requested review from dotlambda and Shou March 15, 2024 13:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 15, 2024
@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Mar 15, 2024 •
edited
Loading

CC (worked on obinskit but not in the nixos org): @theotheroracle @brandonweeks @AntonHakansson

@yu-re-ka yu-re-ka mentioned this pull request Mar 15, 2024
Open
@yu-re-ka yu-re-ka changed the title obinskit: bump electron version obinskit: remove Mar 20, 2024
@yu-re-ka yu-re-ka requested a review from mweinelt March 20, 2024 07:50
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 20, 2024
@yu-re-ka yu-re-ka merged commit 1357b82 into NixOS:master Mar 20, 2024
24 checks passed
@yu-re-ka yu-re-ka deleted the obinskit branch March 20, 2024 16:59
@Fede-26 Fede-26 mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

@Shou Shou Awaiting requested review from Shou

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yu-re-ka @mweinelt @yuyuyureka