breitbandmessung: 3.3.0 -> 3.6.0 #295875
Merged
breitbandmessung: 3.3.0 -> 3.6.0 #295875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
I'd like to add the nixosTests.breitbandmessung to electron.passthru.tests, but that can be done separately |
zi3m5f
reviewed
Mar 14, 2024
Things changed: - Unpin electron version. Upstream updates usually fix electron incompatibilities and we also have a test which can detect them. (NixOS#295770) - Add updater script. It scrapes the upstream website for the current version number. Lets hope the website structure doesn't change too much. - Update to the latest version
B4dM4n
force-pushed
the
update-breitbandmessung
branch
from
69b950a to
fe98800
Compare
yayayayaka
approved these changes
Mar 15, 2024
|
I see the unpinning of electron as slightly risky, and I even doubt that the test can detect most incompatibilities, but I'm willing to give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream updates usually fix electron incompatibilities and we also have a test which can detect them. (electron-bin is chronically outdated #295770)
It scrapes the upstream website for the current version number. Lets hope the website structure doesn't change too much.
Things done
I can't test on darwin currently, but the dmg folder structure is the same between versions, so I suspect it will work.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truebreitbandmessung.tests.breitbandmessungnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.