Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcher: remove #295853

Merged
merged 1 commit into from
Mar 14, 2024
Merged

etcher: remove #295853

merged 1 commit into from
Mar 14, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 14, 2024

Description of changes

#295770

Also closes #261626, since the issue with Electron 25 (still EOL) was never fixed upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 14, 2024
@yu-re-ka yu-re-ka merged commit c9be267 into NixOS:master Mar 14, 2024
27 checks passed
@wegank wegank deleted the etcher-drop branch March 14, 2024 14:10
@dotlambda
Copy link
Member

Even though I don't use etcher I assume it's a very popular application. Maybe we can package a 1.19 pre-release? It also might be possible to build from source.

@wegank
Copy link
Member Author

wegank commented Mar 20, 2024

All 1.19 pre-releases use Electron 25 (EOL in Nixpkgs) and are subject to balena-io/etcher#4150, making the bump failing for users on every other Linux distro (which is why Etcher is at 1.18.14 on Repology, and even that doesn't work). My previous attempt can be found at #261626.

From my experience, building from source offline isn't possible since 1.18.12, due to the transition from package-lock.json to the incomplete npm-shrinkwrap.json, and even for 1.18.11, the source-built Etcher failed to flash any drives for obscure reasons.

I've also tried using the appimage, which succeeded at every step before flashing, which failed due to an unresolved issue: #205082. I think that's the only direction to go, if anyone wants to play around.

So as the maintainer of etcher, I basically found no way to bump this package but keep it at version 1.18.12. I'd suggest existing users (are there really any?) switch to better alternatives, such as rpi-imager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants