Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mieru: init at 3.7.0 #295634

Merged
merged 1 commit into from
Nov 1, 2024
Merged

mieru: init at 3.7.0 #295634

merged 1 commit into from
Nov 1, 2024

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Mar 13, 2024 •
edited
Loading

Description of changes

Add https://github.com/enfein/mieru
q #287770

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Could you update to 2.7.0?

@oluceps
Copy link
Member Author

oluceps commented Apr 9, 2024

Could you update to 2.7.0?

Done.

@oluceps oluceps requested a review from Aleksanaa April 17, 2024 17:36
@Aleksanaa
Copy link
Member

Please check ofborg failure. Seems they moved the tag?

@oluceps oluceps changed the title mieru: init at 2.6.0 mieru: init at 3.7.0 Oct 28, 2024
@oluceps
Copy link
Member Author

oluceps commented Oct 28, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 295634

x86_64-linux

✅ 1 package built:
  • mieru

@Aleksanaa
Copy link
Member

@ofborg eval

Aleksanaa
Aleksanaa reviewed Oct 29, 2024
View reviewed changes
pkgs/by-name/mi/mieru/package.nix Outdated
hash = "sha256-VFQWiihwd0YiLpgTxKUjVd+IkGivsa4jI/jb5ckjFt8=";
};

vendorHash = "sha256-u+faZ5KQQB2U8CdksZ4rqqPrOzxnlHOGHL7tAJobJ18=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash mismatch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash mismatch

I dont think so, since I rebuild on local and #295634 (comment) shows matches well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no

pkgs/by-name/mi/mieru/package.nix Outdated Show resolved Hide resolved
@oluceps
Copy link
Member Author

oluceps commented Oct 29, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 295634

x86_64-linux

✅ 1 package built:
  • mieru

@oluceps
Copy link
Member Author

oluceps commented Oct 29, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 295634

x86_64-linux

✅ 1 package built:
  • mieru

@oluceps oluceps requested a review from Aleksanaa October 29, 2024 15:46
@Aleksanaa
Copy link
Member

Wait. Have you rebased onto latest master? Some vendorHash may become unstable between major Go versions, not sure

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024 •
edited
Loading

Rebased to master, local rebuild success. No hash changed.

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024

Wait. Have you rebased onto latest master? Some vendorHash may become unstable between major Go versions, not sure

nixpkgs-review should has automatically synced the head for testing.

@Aleksanaa
Copy link
Member

Aleksanaa commented Oct 30, 2024 •
edited
Loading

So the worst scenario is that ofborg is mitmed

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 295634

x86_64-linux

✅ 1 package built:
  • mieru

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024 •
edited
Loading

So the worst scenario is that ofborg is mitmed

That's weird. I reproduced the hash mismatch on my another machine

@oluceps @Aleksanaa
mieru: init at 3.7.0
1ca1f67 
Co-authored-by: Aleksana <[email protected]>
@Aleksanaa
Copy link
Member 

error: hash mismatch in fixed-output derivation '/nix/store/pkbdnxbbsxwi9r9y7v8cndkydachrfnx-mieru-3.7.0-go-modules.drv':
         specified: sha256-u+faZ5KQQB2U8CdksZ4rqqPrOzxnlHOGHL7tAJobJ18=
            got:    sha256-woQoqYjdv2TZo66IwNkSHzIHFlu9JH8q/RXGyLlnTTc=
error: 1 dependencies of derivation '/nix/store/waz8kg7ymljxczd981xh9w069w4jc1b7-mieru-3.7.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/shhrp6bcmzh2b2wxkp4dh54m3qgczdwl-review-shell.drv' failed to build

Me too

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024 

error: hash mismatch in fixed-output derivation '/nix/store/pkbdnxbbsxwi9r9y7v8cndkydachrfnx-mieru-3.7.0-go-modules.drv':
         specified: sha256-u+faZ5KQQB2U8CdksZ4rqqPrOzxnlHOGHL7tAJobJ18=
            got:    sha256-woQoqYjdv2TZo66IwNkSHzIHFlu9JH8q/RXGyLlnTTc=
error: 1 dependencies of derivation '/nix/store/waz8kg7ymljxczd981xh9w069w4jc1b7-mieru-3.7.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/shhrp6bcmzh2b2wxkp4dh54m3qgczdwl-review-shell.drv' failed to build

Me too

nix build .#mieru --rebuild
error: some outputs of '/nix/store/gr54akfl5i3rcmdi3ph9jiz3081wwqih-mieru-3.7.0.drv' are not valid, so checking is not possible

oh no

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024

I think I need to verify and repair my nix store first

@oluceps
Copy link
Member Author

oluceps commented Oct 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 295634

x86_64-linux

✅ 1 package built:
  • mieru

@Aleksanaa Aleksanaa merged commit 1e49bf0 into NixOS:master Nov 1, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oluceps @Aleksanaa