python3Packages.bpemb: init at 0.3.5 #295263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
natsukium
reviewed
Mar 18, 2024
Comment on lines
36
to
39
| # pypi builds no tests... | ||
| doCheck = false; |
There was a problem hiding this comment.
Can we fetch the source from GitHub?
It would be a good idea to suggest to upstream to add git tag if necessary.
There was a problem hiding this comment.
Can we fetch the source from GitHub? It would be a good idea to suggest to upstream to add git tag if necessary.
All right. Can I use commit hash in rev for now?
There was a problem hiding this comment.
Sure.
Thanks for opening the issue.
natsukium
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pre-trained subword embeddings in 275 languages, based on Byte-Pair Encoding (BPE)
https://github.com/bheinzerling/bpemb
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.