-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "stdenv: log build hooks as they run" #294625
Conversation
Please consider instead: |
https://nixos.org/manual/nix/stable/command-ref/nix-shell.html#use-as-a--interpreter suggests
so |
Ah, yeah sorry I realized later I misunderstood the issue. Regressing nix-shell -p is definitely a bit of an ouchie. There's sneaky stuff that can be done to the logs that can help though, we'll see how that shakes out in the next iteration. |
Yeah, I'm sad this is getting reverted, though I understand the reason why. @Qyriad, if you want to, we can work together to make the next version. 💪🏻 |
agree. this is a good change and should make its way back in. looking at it yesterday, perhaps just logging to stderr when NIX_DEBUG is > 0 is sufficient. |
we actually noticed there's extra message types we can send to NIX_LOG_FD, which will ostensibly appear on higher verbosity levels of nix itself, get saved properly, as well as not invalidate derivations when changed. we've not tried it yet but we did find the nix-side code for such a thing. this would probably be the ideal situation, to decouple print verbosity from build configuration. |
I started to experiment with it briefly today and it seems to be a viable route so far. |
Reverts #290081
reverting for now -- hopefully this change finds its way back soon
@Qyriad @philiptaron @RaitoBezarius