nixVersions.nix_2_20: init at 2.20.5 #294120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
I've updated the original PR. Not sure why you can't push, I have the box always ticked. |
Comment on lines
-19
to
-25
| # Major.minor versions unaffected by CVE-2024-27297 | ||
| unaffectedByFodSandboxEscape = [ | ||
| "2.3" | ||
| "2.18" | ||
| "2.19" | ||
| "2.20" | ||
| ]; |
There was a problem hiding this comment.
Should we remove this in the original PR, too? I am not sure.
There was a problem hiding this comment.
No, because then you need to upgrade ALL the other Nix. Not just one.
There was a problem hiding this comment.
Good, then we leave it as it is in my PR. I just wasn't sure if I missed something or this was a bad rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
original PR: #285264
This is the squashed version.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.