blender: cleanup #293514
Merged
blender: cleanup #293514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Format to draft RFC 0166 style (via nixfmt-rfc-style) - Alphabetize lists unless there is a somewhat-apparent reason not to - Reorder attrs based roughly on the order they are used by the builder
Otherwise all these references have to be updated whenever the Python version is changed.
When used, ensure the scope is narrow. https://nix.dev/guides/best-practices#with-scopes
This seems to no longer be necessary, I can successfully build with cudaSupport and perform a CUDA and OptiX render.
It’s always defined.
drupol
reviewed
Mar 5, 2024
This makes them match what the fn param names *would* be, making it
easier to refactor e.g. to `{ python3Packages, ... }: mkDerivation …` in
the future if desired. It also potentially reduces first-glance
confusion that it might be Python 2 in-use.
Leave the passthru names as-is to preserve backwards-compatibility, but
also as there appears to be some precedent for naming them like this.
amarshall
force-pushed
the
blender-cleanup2
branch
from
8adad26
to
c92e91b
Compare
veprbl
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Intention here is no functional changes (though the derivation itself does change due to reordering in lists). Motivation is to make it easier to contribute future changes to blender without having to undergo piecemeal cleanups to align with more modern nixpkgs style, while also producing more compact, obvious diffs.
Incorporated some feedback from stalled draft PR #257780.
Things done
Have verified the only difference between the generated derivations before-and-after is inconsequential reordering (e.g. of buildInputs; as is expected).
nix-diff, etc. output
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.