Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyloggingpp: Build with C++14 instead of C++11. #290673

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

simonhollingshead
Copy link
Contributor

Description of changes

Fixes build issues caused by #282245.

Note that there is a failure in the rebuild - but haven-cli is already failing at HEAD. This change stops the failure being in a dependency and returns the existing failing behaviour visible on master.

abumq/easyloggingpp#830 was filed over a year ago asking upstream what to do. As it is, (as per that bug) other distros like Fedora are now forcing C++14-ness upon easyloggingpp, so we're doing the same here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes issues with newer versions of gtest.
@ofborg ofborg bot requested a review from acowley February 22, 2024 18:10
@lukegb lukegb merged commit 701f65d into NixOS:staging-next Feb 23, 2024
25 checks passed
@simonhollingshead simonhollingshead deleted the easyloggingpp-gtest branch March 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants