Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffpb: init at 0.4.1 #288955

Merged
merged 1 commit into from
Dec 15, 2024
Merged

ffpb: init at 0.4.1 #288955

merged 1 commit into from
Dec 15, 2024

Conversation

CaptainJawZ
Copy link
Contributor

Description of changes

Init for ffpb https://github.com/althonos/ffpb

ffpb is an FFmpeg progress formatter. It will attempt to display a nice progress bar in the output, based on the raw ffmpeg output, as well as an adaptative ETA timer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 15, 2024
@nix-owners nix-owners bot requested a review from natsukium October 30, 2024 02:57
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@FliegendeWurst FliegendeWurst added the needs_merger (old Marvin label, do not use) label Nov 12, 2024
@FliegendeWurst FliegendeWurst removed the needs_merger (old Marvin label, do not use) label Dec 13, 2024
pkgs/by-name/ff/ffpb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ff/ffpb/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ff/ffpb/package.nix Show resolved Hide resolved
Co-authored-by: Arne Keller <[email protected]>
@CaptainJawZ
Copy link
Contributor Author

Thank you for your feedback and the info @FliegendeWurst
I've implemented your changes and pushed a new version.

Let me know if there is anything else I could adjust.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@FliegendeWurst FliegendeWurst merged commit 67f5b45 into NixOS:master Dec 15, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants