feishin: 0.5.1 -> 0.5.3, build from source

[dotlambda]

This currently fails to run with

App threw an error during load
Error: Cannot find module 'mpris-service'
Require stack:
- /nix/store/scd452047r76hyp2506zmhvrlv5jgrha-feishin-0.5.3/opt/feishin/resources/app.asar/dist/main/main.js
- /nix/store/pdwgakam5llj22xi7d7vpxbldwgs9inc-electron-unwrapped-27.2.3/libexec/electron/resources/default_app.asar/main.js
- 
    at node:internal/modules/cjs/loader:1084:15
    at Function._resolveFilename (node:electron/js2c/browser_init:2:116646)
    at node:internal/modules/cjs/loader:929:27
    at Function._load (node:electron/js2c/asar_bundle:2:13327)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:121:18)
    at 77178 (/nix/store/scd452047r76hyp2506zmhvrlv5jgrha-feishin-0.5.3/opt/feishin/resources/app.asar/dist/main/main.js:14:609796)
    at n (/nix/store/scd452047r76hyp2506zmhvrlv5jgrha-feishin-0.5.3/opt/feishin/resources/app.asar/dist/main/main.js:14:805763)
    at 91312 (/nix/store/scd452047r76hyp2506zmhvrlv5jgrha-feishin-0.5.3/opt/feishin/resources/app.asar/dist/main/main.js:14:543748)
    at n (/nix/store/scd452047r76hyp2506zmhvrlv5jgrha-feishin-0.5.3/opt/feishin/resources/app.asar/dist/main/main.js:14:805763)

because mpris-service is specified as a dependency in https://github.com/jeffvli/feishin/blob/v0.5.3/release/app/package.json.
It would be nice if someone who actually uses the package could pick up the work.

Description of changes

Diff: jeffvli/feishin@refs/tags/v0.5.1...v0.5.3

Changelog: https://github.com/jeffvli/feishin/releases/tag/v0.5.3

fixes #287765
cc @nadir-ishiguro

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[onny]

This looks nice! So we would need mpris-service packaged? #288274

[dotlambda]

This looks nice! So we would need mpris-service packaged? #288274

No, we'd need to add another expression that runs buildNpmPackage on the subdirectory.

[jlbribeiro]

Hey @dotlambda, thanks for this PR!

Just to keep it up-to-date, jeffvli/feishin v0.6.1 has been released.

Notice the release notes mention having downgraded from Electron v27 to v26 to restore compatibility with macOS 10.13 and 10.14 (jeffvli/feishin#534), but that issue was later re-opened as that didn't fix it:

I know for sure that Electron v25 works, but we need to find out which version if any v26 will work.

[nadir-ishiguro]

Well, that's a bit worrying. Downgrading Electron to support deprecated macOS versions seems like an odd choice to me.