factor-lang: Restructure package for easier extension #287852
Conversation
ofborg
bot
added
11.by: package-maintainer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3438 |
spacefrogg
force-pushed
the
factor-rewrap
branch
from
81d9d58 to
3c888e6
Compare
spacefrogg
force-pushed
the
factor-rewrap
branch
3 times, most recently
from
b99ea67 to
3c9a4d2
Compare
github-actions
bot
added
6.topic: nixos
|
I have also added a forgotten feature |
spacefrogg
force-pushed
the
factor-rewrap
branch
from
3c9a4d2 to
b806d09
Compare
|
Regarding the change in |
spacefrogg
force-pushed
the
factor-rewrap
branch
2 times, most recently
from
5c43520 to
7894f4d
Compare
The problem with codeowners is, that it doesn't properly work if you do not have merge permissions :( |
pkgs/development/compilers/factor-lang/mk-factor-application.nix
Outdated
Show resolved
Hide resolved
spacefrogg
force-pushed
the
factor-rewrap
branch
from
7894f4d to
1e36ecc
Compare
spacefrogg
force-pushed
the
factor-rewrap
branch
from
1e36ecc to
473372a
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3696 |
wegank
added
the
2.status: merge conflict
spacefrogg
force-pushed
the
factor-rewrap
branch
from
473372a to
e37e545
Compare
spacefrogg
removed
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
spacefrogg
force-pushed
the
factor-rewrap
branch
4 times, most recently
from
2147711 to
00b237d
Compare
wegank
added
the
2.status: merge conflict
spacefrogg
force-pushed
the
factor-rewrap
branch
from
00b237d to
a04f874
Compare
spacefrogg
force-pushed
the
factor-rewrap
branch
from
e5a05b7 to
f8bc2a2
Compare
nix-owners
bot
requested review from
fricklerhandwerk,
GetPsyched and
hsjobeki
spacefrogg
force-pushed
the
factor-rewrap
branch
from
f8bc2a2 to
9e253e9
Compare
| Additional attribute that are understood by `buildFactorApplication`: | ||
| - `vocabName` is the path to the vocabulary to be deployed relative to the source root. | ||
| So, directory `foo/` from the example above could be `extra/deep/down/foo`. | ||
| This allows you to maintain Factor's vocabulary hierarchy and distribute the same source tree as a stand-alone application and as a library in the Factor development environment via the `extraVocabs` attribute. | ||
| - `binName` is the name of the resulting binary in `/bin/`. | ||
| It defaults to the last directory component in `vocabName`. | ||
| It is also added as the `meta.mainProgram` attribute to facilitate `nix run`. | ||
| - `enableUI` is `false` by default. | ||
| Set this to `true` when you ship a graphical application. | ||
| - `extraLibs` adds additional libraries as runtime dependencies. | ||
| Defaults to `[]` and is concatenated with `runtimeLibs` from the used factor-lang package. | ||
| Use `factor-minimal` to minimize the closure of runtime libraries. | ||
| - `extraPaths` adds additional binaries to the runtime PATH environment variable (without adding their libraries, as well). | ||
| Defaults to `[]` and is concatenated with `defaultBins` and `binPackages` from the used factor-lang package. | ||
| Use `factor-minimal` to minimize the closure of runtime libraries. | ||
| - `deployScriptText` is the actual deploy Factor file that is executed to deploy the application. | ||
| You can change it if you need to perform additional computation during deployment. | ||
| - `factor-lang` overrides the Factor package to use to deploy this application, which also affects the default library bindings and programs in the runtime PATH. | ||
| It defaults to `factor-lang` when `enableUI` is turned on and `factor-no-gui` when it is turned off. | ||
| Applications that use only Factor libraries without external bindings or programs may set this to `factor-minimal` or `factor-minimal-gui`. |
There was a problem hiding this comment.
It's not a hard rule for me personally, because documenting all that is already great in itself, but we do have a rule for using definition lists for function arguments -- that will help migrating whatever is done to different formats programmatically.
Sorry for picking things piecemeal. I'm out again, I primarily just monitor how the redirects system is being picked up and whether it produces excess friction.
There was a problem hiding this comment.
Thanks, I addressed your comments.
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
2.status: merge conflict
spacefrogg
force-pushed
the
factor-rewrap
branch
from
9e253e9 to
b5ffdf3
Compare
This is resolved. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4919 |
wegank
added
the
2.status: merge conflict
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.