wastebin: init at 2.4.3 #287455
Merged
wastebin: init at 2.4.3 #287455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
2.status: merge conflict
pinpox
force-pushed
the
init-wastebin
branch
2 times, most recently
from
ef8d8f0 to
60345fa
Compare
h7x4
added
8.has: module (new)
fsnkty
reviewed
Feb 14, 2024
pinpox
force-pushed
the
init-wastebin
branch
from
60345fa to
577e48e
Compare
fsnkty
suggested changes
Feb 21, 2024
| }; | ||
| }; | ||
|
|
||
| default = {}; |
There was a problem hiding this comment.
Suggested change
| default = {}; |
does this not do nothing?
There was a problem hiding this comment.
The module failed to evaluate when nothing is set otherwise, so I added a empty default which is not `null``
pinpox
force-pushed
the
init-wastebin
branch
from
577e48e to
dba3056
Compare
ofborg
bot
added
the
11.by: package-maintainer
|
Result of 1 package blacklisted:
1 package built:
|
Add module and test for wastebin
pinpox
force-pushed
the
init-wastebin
branch
from
dba3056 to
3bc61ad
Compare
wegank
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3728 |
wegank
added
the
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.