Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pysolfc: 2.20.1 -> 2.21.0 #287161

Merged
merged 1 commit into from
Feb 14, 2024
Merged

pysolfc: 2.20.1 -> 2.21.0 #287161

merged 1 commit into from
Feb 14, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Feb 8, 2024 •
edited
Loading

Description of changes

Fixes #286931.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@l0b0 l0b0 marked this pull request as draft February 8, 2024 06:41
@l0b0 l0b0 marked this pull request as ready for review February 8, 2024 07:00
@l0b0 l0b0 requested review from dotlambda and kierdavis February 8, 2024 07:00
dotlambda
dotlambda reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#277994

pkgs/games/pysolfc/default.nix Outdated Show resolved Hide resolved
pkgs/games/pysolfc/default.nix Outdated Show resolved Hide resolved
pkgs/games/pysolfc/default.nix Outdated Show resolved Hide resolved
@l0b0 @dotlambda
pysolfc: 2.20.1 -> 2.21.0
ea67eb2 
Additional idiomatic changes:

- Use lowercase package name
- Use mirror source links

Co-authored-by: Robert Schütz <[email protected]>
@l0b0 l0b0 requested a review from dotlambda February 8, 2024 07:04
@drupol drupol merged commit cdefe71 into NixOS:master Feb 14, 2024
27 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Merged
1 task
@l0b0 l0b0 deleted the bump-pysolfc branch February 14, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kierdavis kierdavis Awaiting requested review from kierdavis

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
0.kind: bug Something is broken 6.topic: games 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pysol.py crashes with "module 'PIL.Image' has no attribute 'ANTIALIAS'"
3 participants
@l0b0 @dotlambda @drupol