Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expat: 2.5.0 -> 2.6.0 #287040

Merged
merged 1 commit into from
Feb 14, 2024
Merged

expat: 2.5.0 -> 2.6.0 #287040

merged 1 commit into from
Feb 14, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 7, 2024

https://github.com/libexpat/libexpat/blob/R_2_6_0/expat/Changes
https://blog.hartwork.org/posts/expat-2-6-0-released/

Fixes: CVE-2023-54245, CVE-2024-52426

Regresses the cpython testsuite: python/cpython#115133.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt marked this pull request as ready for review February 10, 2024 15:42
@mweinelt
Copy link
Member Author

We're not actually running the cpython test suite and the regression seems to be limited to that for now, even though there exist doubts about the effective removal of the incremental parsing capability.

python/cpython#115138 (comment)

@risicle
Copy link
Contributor

risicle commented Feb 12, 2024

Cherry-picked to staging-next for testing, no new failures building passthru.tests on macos 12 x86_64 & nixos x86_64 (excluding haskell test, ghc too big). Also got no new failures from pkgsStatic.expat.tests on nixos x86_64.

@hartwork
Copy link
Contributor

Regresses the cpython testsuite: python/cpython#115133.

@mweinelt just a quick note that the CPython issue has been closed by merge of pull request python/cpython#115164 by now.

@risicle
Copy link
Contributor

risicle commented Feb 12, 2024

Same goes for pkgsCross.aarch64-multiplatform.expat.tests and pkgsi686Linux.expat.tests

@risicle risicle merged commit beb8576 into NixOS:staging Feb 14, 2024
23 checks passed
@matshch matshch mentioned this pull request Mar 14, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants