Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gerbolyze: init at v3.1.7, gerbonara: init at v1.2.0 #286368

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

Wulfsta
Copy link
Member

@Wulfsta Wulfsta commented Feb 4, 2024

Description of changes

Add Gerbolyze and its dependencies. Thanks to @ghpzin for the help with svg-flatten.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 4, 2024
pkgs/by-name/ge/gerbolyze/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ge/gerbolyze/package.nix Show resolved Hide resolved
pkgs/development/python-modules/gerbonara/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Wulfsta Wulfsta requested a review from jtbx February 6, 2024 03:28
@Wulfsta Wulfsta force-pushed the gerbonara branch 2 times, most recently from 6b6ab14 to f2bba5b Compare February 6, 2024 03:30
Copy link
Member

@jtbx jtbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 6, 2024
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 286368 run on x86_64-linux 1

4 packages built:
  • gerbolyze
  • gerbolyze.dist
  • python311Packages.gerbonara
  • python311Packages.gerbonara.dist

LGTM for the most part, just some nits.

Would it make sense to split of svg-flatten into a separate package? If so consider moving its definition to a separate folder in by-name and inherit (gerbolyze) version src;

pkgs/by-name/ge/gerbolyze/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ge/gerbolyze/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ge/gerbolyze/package.nix Show resolved Hide resolved
pkgs/by-name/ge/gerbolyze/package.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/gerbonara/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/ge/gerbolyze/package.nix Outdated Show resolved Hide resolved
@Wulfsta
Copy link
Member Author

Wulfsta commented Feb 15, 2024

Would it make sense to split of svg-flatten into a separate package? If so consider moving its definition to a separate folder in by-name and inherit (gerbolyze) version src;

I don't think svg-flatten should be a separate package. It seems a handful of projects exist with this name, and Gerbolyze seems to be the only one that uses this piece of code. I had initially split it off, but decided to do it this way after some consideration.

@Wulfsta Wulfsta requested a review from pbsds February 15, 2024 22:02
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 16, 2024
@pbsds
Copy link
Member

pbsds commented Feb 16, 2024

ofborg darwin is unhappy, consider marking it broken on darwin

@Wulfsta
Copy link
Member Author

Wulfsta commented Feb 16, 2024

I don't see a reason that svg-flatten shouldn't be able to build on darwin, let me see if I can fix it by twiddling with the build flags...

Couldn't get it working on darwin, making it linux specific.

@pbsds pbsds merged commit 39711b1 into NixOS:master Feb 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants