-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gerbolyze: init at v3.1.7, gerbonara: init at v1.2.0 #286368
Conversation
6b6ab14
to
f2bba5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 286368
run on x86_64-linux 1
4 packages built:
- gerbolyze
- gerbolyze.dist
- python311Packages.gerbonara
- python311Packages.gerbonara.dist
LGTM for the most part, just some nits.
Would it make sense to split of svg-flatten
into a separate package? If so consider moving its definition to a separate folder in by-name
and inherit (gerbolyze) version src;
I don't think |
ofborg darwin is unhappy, consider marking it broken on darwin |
Couldn't get it working on darwin, making it linux specific. |
Description of changes
Add Gerbolyze and its dependencies. Thanks to @ghpzin for the help with
svg-flatten
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.