Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrive: init at 0.10.0 #285894

Merged
merged 1 commit into from
Dec 22, 2024
Merged

skrive: init at 0.10.0 #285894

merged 1 commit into from
Dec 22, 2024
+36 −0

Conversation

freyacodes
Copy link
Contributor

Description of changes

This adds Skrive, a medicine dosage logger for the terminal

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

dotlambda
dotlambda reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use fetchFromGitHub.

pkgs/by-name/sk/skrive/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sk/skrive/package.nix Outdated Show resolved Hide resolved
@freyacodes freyacodes force-pushed the skrive branch 2 times, most recently from 08b2375 to 135511a Compare February 6, 2024 20:14
@freyacodes freyacodes changed the title skrive: init at 0.5.0 skrive: init at 0.6.0 Feb 6, 2024
@freyacodes freyacodes changed the title skrive: init at 0.6.0 skrive: init at 0.6.1 Feb 7, 2024
@freyacodes freyacodes force-pushed the skrive branch 2 times, most recently from d2a59fb to f39c93b Compare February 9, 2024 12:49
@freyacodes freyacodes changed the title skrive: init at 0.6.1 skrive: init at 0.6.2 Feb 9, 2024
@freyacodes freyacodes changed the title skrive: init at 0.6.2 skrive: init at 0.7.0 Feb 9, 2024
dotlambda
dotlambda previously requested changes Feb 9, 2024
View reviewed changes
pkgs/by-name/sk/skrive/package.nix Outdated Show resolved Hide resolved
@freyacodes freyacodes changed the title skrive: init at 0.7.0 skrive: init at 0.9.0 Feb 25, 2024
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 285894 run on x86_64-linux 1

1 package built:
  • skrive

@Scrumplex Scrumplex added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 26, 2024
@freyacodes freyacodes force-pushed the skrive branch 2 times, most recently from de2efc3 to fc17e0c Compare July 31, 2024 22:08
@freyacodes freyacodes changed the title skrive: init at 0.9.0 skrive: init at 0.10.0 Jul 31, 2024
@freyacodes freyacodes requested a review from dotlambda July 31, 2024 22:12
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 285894 run on x86_64-linux 1

1 package built:
  • skrive

@Scrumplex
Copy link
Member

@dotlambda could you approve this PR? It's blocking the merge

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@FliegendeWurst FliegendeWurst merged commit e89c48f into NixOS:master Dec 22, 2024
28 checks passed
@freyacodes freyacodes deleted the skrive branch December 22, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freyacodes @Scrumplex @dotlambda @FliegendeWurst @wegank