Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handheld-daemon: 1.1.0 -> 1.1.4 #284928

Closed
wants to merge 1 commit into from

Conversation

appsforartists
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 30, 2024
@appsforartists
Copy link
Contributor Author

@antheas would /sys/kernel/config suffice for this?

@antheas
Copy link

antheas commented Jan 30, 2024

You can't create files in /sys as far as I know

@appsforartists
Copy link
Contributor Author

It's already a mount-point for configfs though. You wouldn't have to create it.

I guess I should test if you can create folders inside that configfs mount-point.

@appsforartists
Copy link
Contributor Author

mkdir /sys/kernel/config/iio
Permission denied

🫤

@antheas
Copy link

antheas commented Jan 30, 2024

You can follow the steps in this file and if they work it will be fine:
https://github.com/hhd-dev/hhd/blob/c074cb0e3e13ab18fd150eb36df70044ede45038/src/hhd/controller/physical/imu.py#L415

Essentially, assume $conf is the mount dir.

sudo modprobe industrialio-sw-trigger
sudo modprobe iio-trig-sysfs
sudo modprobe iio-trig-hrtimer

sudo mkdir -p $conf
sudo mount -t configfs none $conf
sudo mkdir -p $conf/iio/triggers/hrtimer/hhd

Then at closing

sudo rmdir $conf/iio/triggers/hrtimer/hhd

Try running with $conf as /sys/kernel/config. Although I guess the mount command will fail if you do that.

@appsforartists
Copy link
Contributor Author

Per @antheas:

turns out writing to /var works fine
so its not needed
so you can close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants