Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poco: 1.12.5p2 -> 1.13.2 #283809

Merged
merged 3 commits into from
Apr 1, 2024
Merged

poco: 1.12.5p2 -> 1.13.2 #283809

merged 3 commits into from
Apr 1, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/poco/versions.

meta.description for poco is: Cross-platform C++ libraries with a network/internet focus

meta.homepage for poco is: https://pocoproject.org/

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.13.0 in filename of file in /nix/store/pls9ab1rsjm8vxnxpakpnljh4b8jzpbz-poco-1.13.0
Rebuild report (if merged into master) (click to expand) 
10 total rebuild path(s)

10 package rebuild(s)

First fifty rebuilds by attrpath
craftos-pc
ioquake3
litebrowser
mumble
mumble_overlay
murmur
poco
pothos
quake3demo
sanjuuni
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/pls9ab1rsjm8vxnxpakpnljh4b8jzpbz-poco-1.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A poco https://github.com/r-ryantm/nixpkgs/archive/c617dc49654c2bc40ac692c86ff0f1ece8480570.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c617dc49654c2bc40ac692c86ff0f1ece8480570#poco

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/pls9ab1rsjm8vxnxpakpnljh4b8jzpbz-poco-1.13.0
ls -la /nix/store/pls9ab1rsjm8vxnxpakpnljh4b8jzpbz-poco-1.13.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:
  • litebrowser
  • sanjuuni
8 packages built:
  • craftos-pc
  • ioquake3
  • mumble
  • mumble_overlay
  • murmur
  • poco
  • pothos
  • quake3demo
Maintainer pings

cc @orivej @tomodachi94 for testing.

@ofborg ofborg bot requested a review from tomodachi94 January 25, 2024 18:35
@risicle risicle mentioned this pull request Feb 3, 2024
Closed
@risicle risicle marked this pull request as draft February 3, 2024 13:24
@risicle
Copy link
Contributor

risicle commented Feb 3, 2024

See #281999

@risicle risicle mentioned this pull request Feb 3, 2024
Merged
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@r-ryantm r-ryantm changed the title poco: 1.12.5 -> 1.13.0 poco: 1.12.5p2 -> 1.13.2 Mar 25, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/poco/versions.

meta.description for poco is: Cross-platform C++ libraries with a network/internet focus

meta.homepage for poco is: https://pocoproject.org/

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.13.2 in filename of file in /nix/store/fdg0blhzyc8zs8mm5jlc6fyd8sriyznq-poco-1.13.2
Rebuild report (if merged into master) (click to expand) 
12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath
craftos-pc
ioq3-scion
ioquake3
litebrowser
mumble
mumble_overlay
murmur
poco
pothos
quake3demo
sanjuuni
vscode-extensions.jackmacwindows.craftos-pc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fdg0blhzyc8zs8mm5jlc6fyd8sriyznq-poco-1.13.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A poco https://github.com/r-ryantm/nixpkgs/archive/72f2352214dc0c4621b3559c9d15dfdda782218a.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/72f2352214dc0c4621b3559c9d15dfdda782218a#poco

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fdg0blhzyc8zs8mm5jlc6fyd8sriyznq-poco-1.13.2
ls -la /nix/store/fdg0blhzyc8zs8mm5jlc6fyd8sriyznq-poco-1.13.2/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:
  • litebrowser
  • sanjuuni
11 packages built:
  • craftos-pc
  • ioq3-scion
  • ioquake3
  • mumble
  • mumble_overlay
  • murmur
  • poco
  • poco.dev
  • pothos
  • quake3demo
  • vscode-extensions.jackmacwindows.craftos-pc
Maintainer pings

cc @orivej @tomodachi94 for testing.

@ofborg ofborg bot added 10.rebuild-linux: 11-100 and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 1-10 labels Mar 25, 2024
@tomodachi94 tomodachi94 added the 8.has: package (update) This PR updates a package to a newer version label Mar 25, 2024
@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

litebrowser appears to build if bumped to the latest unstable. Will push.

@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

I think the issue with sanjuuni is poco 0.13.x's minimum supported c++ version is 17, while even the latest version of sanjuuni tries to build everything with c++11.

@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

This builds. Does it work for you @tomodachi94 ?

@risicle risicle marked this pull request as ready for review March 25, 2024 22:09
tomodachi94
tomodachi94 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll notify upstream of the requirement for a newer C++ version in Sanjuuni.

@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

Hmm.. litebrowser fails to build on macos now... 🤔

tomodachi94 added a commit to tomodachi94/sanjuuni that referenced this pull request Mar 25, 2024
@tomodachi94
Bump C++ requirement to C++17
dc82d10 
The 1.13.0 release of Poco requires a newer version of C++, specifically
C++17. The configuration phase will fail to find the Poco headers with
an older C++ version.

Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG
Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26
Relevant discussion: NixOS/nixpkgs#283809 (comment)
@tomodachi94 tomodachi94 mentioned this pull request Mar 25, 2024
Merged
tomodachi94 added a commit to tomodachi94/sanjuuni that referenced this pull request Mar 25, 2024
@tomodachi94
Bump C++ requirement to C++17
434e8fb 
The 1.13.0 release of Poco requires a newer version of C++, specifically
C++17. The configuration phase will fail to find the Poco headers with
an older C++ version.

Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG
Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26
Relevant discussion: NixOS/nixpkgs#283809 (comment)
@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

litehtml/litebrowser-linux#19

@ofborg ofborg bot requested review from fgaz and tomodachi94 March 25, 2024 22:43
tomodachi94 added a commit to tomodachi94/sanjuuni that referenced this pull request Mar 25, 2024
@tomodachi94
Bump C++ requirement to C++17
0562f71 
The 1.13.0 release of Poco requires a newer version of C++, specifically
C++17. The configuration phase will fail to find the Poco headers with
an older C++ version.

Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG
Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26
Relevant discussion: NixOS/nixpkgs#283809 (comment)
tomodachi94 added a commit to tomodachi94/sanjuuni that referenced this pull request Mar 25, 2024
@tomodachi94
Bump C++ requirement to C++17
f2164bc 
The 1.13.0 release of Poco requires a newer version of C++, specifically
C++17. The configuration phase will fail to find the Poco headers with
an older C++ version.

Changes to ./configure may be reproduced by running autoconf v2.72.

Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG
Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26
Relevant discussion: NixOS/nixpkgs#283809 (comment)
@risicle
Copy link
Contributor

risicle commented Mar 25, 2024

pkgsStatic, pkgsMusl, pkgsCross.aarch64-multiplatform, pkgsi686Linux variants build fine. Perhaps at what point we just accept the macos breakage.

@fgaz
Copy link
Member

fgaz commented Mar 26, 2024

Perhaps at what point we just accept the macos breakage.

It's fine by me, but please set meta.broken appropriately.

@tomodachi94
Copy link
Member

This builds. Does it work for you @tomodachi94 ?

On second thought, could this be changed to a fetchpatch from this commit, which was just merged into upstream earlier today? The C++ version update is applied more consistently, including updating the ./configure script to fully run its checks for C++17.

@risicle risicle merged commit 0333eeb into NixOS:master Apr 1, 2024
23 checks passed
@r-ryantm r-ryantm deleted the auto-update/poco branch April 2, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz Awaiting requested review from fgaz

@tomodachi94 tomodachi94 Awaiting requested review from tomodachi94

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-ryantm @risicle @fgaz @tomodachi94 @wegank