Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolicator: fix build on Darwin #282777

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

reckenrode
Copy link
Contributor

Description of changes

Add the SystemConfiguration framework as a buildInput. Otherwise, symbolicator fails to link on Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Add the SystemConfiguration framework as a `buildInput`. Otherwise,
symbolicator fails to link on Darwin.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 22, 2024
@ofborg ofborg bot requested a review from figsoda January 22, 2024 04:16
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 22, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 22, 2024
@wegank
Copy link
Member

wegank commented Jan 22, 2024

Also, the failure was unnoticed in #270482.

@wegank wegank merged commit 2a7e91d into NixOS:master Jan 22, 2024
27 of 28 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants