-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clash-{nyanpasu,verge-rev}: init #281360
clash-{nyanpasu,verge-rev}: init #281360
Conversation
someone told me that I cannot overrides other packages as a package in nixpkgs... fine. |
I didn't test the module (yet), as it is 1 AM for me... will continue tomorrow. |
seems to be all working now. should be ready for review. |
(I have no idea why is it automatically requesting piegamesde and Janik-Haag to review...) |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you building the packages from source?
AFAIK it's using pnpm, which I've heard Nix isn't good at. |
uff yeah you are right. I'm not sure what I find uglier using that cursed pnpm fetcher (like the pot package does) or repackging deb files of foss software (this also has actual disadvantages like libs getting installed more often and security updates getting harder if they are possible at all). There also is https://github.com/NixOS/GSoC/blob/main/ideas/2024.md#nixpkgs-pnpm-tooling but it will take a few more month to exist if it ends up existing at all. |
|
33fec78
to
2e3b032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff lgtm, Please squash clash-{nyanpasu,verge-rev}: use nixpkgs' clash-meta binary into clash-nyanpasu: init at 1.4.5 and clash-verge-rev: init at 1.5.4
e4db076
to
91a6f44
Compare
Description of changes
clash-nyanpasu: init at 1.4.5
clash-verge-rev: init at 1.5.4
These are two clash-verge forks.
My first two package in nixpkgs, please tell if anything need to be changed. :-)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.