poetry: fix up dependencies #280522
poetry: fix up dependencies #280522
Conversation
| @@ -59,8 +59,8 @@ buildPythonPackage rec { | |||
| ]; | |||
|
|
|||
| pythonRelaxDeps = [ | |||
| # only pinned to avoid dependency on Rust | |||
| "jsonschema" | |||
| # platformdirs 4.x is backwards compatible; https://github.com/python-poetry/poetry/commit/eb80d10846f7336b0b2a66ce2964e72dffee9a1c | |||
There was a problem hiding this comment.
Because there is nothing meaningful to fetch.
There was a problem hiding this comment.
i.e. that commit doesn't apply cleanly?
There was a problem hiding this comment.
To clarify, you want me to fetch a patch, so that it fails to apply on the next bump, so we remember to remove it again?
There was a problem hiding this comment.
To clarify, you want me to fetch a patch, so that it fails to apply on the next bump, so we remember to remove it again?
We don't update poetry in the batch upgrades, so we won't forget to remove the patch.
Anyway, if you prefer pythonRelaxDeps that's fine with me though I can't guarantee I won't forget to remove it.
There was a problem hiding this comment.
Poetry can break in python-updates, because it is a leaf-package, and we don't pay much attention to those. I have a slight preference for not pulling another FOD for this minor issue, since the hook has that exact use case.
> Checking runtime dependencies for poetry-1.7.1-py3-none-any.whl > - fastjsonschema not installed > - platformdirs<4.0.0,>=3.0.0 not satisfied by version 4.0.0
dotlambda
force-pushed
the
poetry-deps
branch
from
5753c08 to
7995c92
Compare
Following from NixOS#280522, the xattr dependency still failed the pythonRuntimeDepsCheck hook, likely overlooked because it is a Darwin-only dep: > Checking runtime dependencies for poetry-1.7.1-py3-none-any.whl > - xattr<0.11.0,>=0.10.0 not satisfied by version 1.0.0 From 0.10.0 to 1.0.0 there are no functional changes with compatibility implications, only dropped support for Python 2.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.