Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lshw: unstable-2023-03-20 -> 02.20 #279592

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 8, 2024

Description of changes

  • Migrate to by-name
  • Bump: unstable-2023-03-20 -> 02.20 (actually called B02.20 upstream, but we have a workaround because limitations in our Repology export)
  • Enable GUI by default (and fix it)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 8, 2024
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 279592 run on x86_64-linux 1

1 package marked as broken and skipped:
  • deepin.deepin-clone
58 packages built:
  • deepin.dde-app-services
  • deepin.dde-appearance
  • deepin.dde-application-manager
  • deepin.dde-calendar
  • deepin.dde-clipboard
  • deepin.dde-control-center
  • deepin.dde-control-center.dev
  • deepin.dde-daemon
  • deepin.dde-device-formatter
  • deepin.dde-dock
  • deepin.dde-dock.dev
  • deepin.dde-file-manager
  • deepin.dde-gsettings-schemas
  • deepin.dde-launchpad
  • deepin.dde-network-core
  • deepin.dde-polkit-agent
  • deepin.dde-qt-dbus-factory
  • deepin.dde-session
  • deepin.dde-session-shell
  • deepin.dde-session-shell.dev
  • deepin.dde-session-ui
  • deepin.dde-widgets
  • deepin.deepin-album
  • deepin.deepin-calculator
  • deepin.deepin-camera
  • deepin.deepin-compressor
  • deepin.deepin-draw
  • deepin.deepin-editor
  • deepin.deepin-image-viewer
  • deepin.deepin-movie-reborn
  • deepin.deepin-movie-reborn.dev
  • deepin.deepin-music
  • deepin.deepin-picker
  • deepin.deepin-reader
  • deepin.deepin-screen-recorder
  • deepin.deepin-screensaver
  • deepin.deepin-shortcut-viewer
  • deepin.deepin-system-monitor
  • deepin.deepin-terminal
  • deepin.deepin-turbo
  • deepin.deepin-voice-note
  • deepin.dpa-ext-gnomekeyring
  • deepin.dtkcore
  • deepin.dtkcore.dev
  • deepin.dtkcore.doc
  • deepin.dtkdeclarative
  • deepin.dtkdeclarative.dev
  • deepin.dtkdeclarative.doc
  • deepin.dtkgui
  • deepin.dtkgui.dev
  • deepin.dtkgui.doc
  • deepin.dtkwidget
  • deepin.dtkwidget.dev
  • deepin.dtkwidget.doc
  • deepin.image-editor
  • deepin.qt5integration
  • lshw
  • webex

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except by pname, in L21, LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 8, 2024
@thiagokokada thiagokokada merged commit f0fea03 into NixOS:master Jan 8, 2024
23 of 24 checks passed
@thiagokokada thiagokokada deleted the bump-lshw branch January 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants