archivebox: 0.6.2 -> 0.7.2 #277647
Merged
archivebox: 0.6.2 -> 0.7.2 #277647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build postlight-parser readability-extractor |
dotlambda
reviewed
Dec 30, 2023
viraptor
force-pushed
the
bump-archivebox-2
branch
from
908e02d to
082e50d
Compare
Added where they exist and aren't auto-propagated already. |
viraptor
force-pushed
the
bump-archivebox-2
branch
from
082e50d to
648e9b7
Compare
ofborg
bot
added
8.has: package (new)
dotlambda
reviewed
Jan 5, 2024
| ]; | ||
|
|
||
| makeWrapperArgs = [ | ||
| "--prefix PATH : ${lib.makeBinPath [ curl wget ripgrep nodejs readability-extractor postlight-parser ]}" |
There was a problem hiding this comment.
Suggested change
| "--prefix PATH : ${lib.makeBinPath [ curl wget ripgrep nodejs readability-extractor postlight-parser ]}" | |
| "--prefix PATH : ${lib.makeBinPath [ curl wget ripgrep readability-extractor postlight-parser ]}" |
I can't find any JS code in the repo.
There was a problem hiding this comment.
It's used through dependencies and needs USE_NODE, but you're right it doesn't need to be in the path.
viraptor
force-pushed
the
bump-archivebox-2
branch
from
648e9b7 to
057cdd4
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3249 |
dotlambda
reviewed
Jan 10, 2024
dotlambda
reviewed
Jan 10, 2024
dotlambda
reviewed
Jan 10, 2024
viraptor
force-pushed
the
bump-archivebox-2
branch
2 times, most recently
from
291ba4b to
07f5bd3
Compare
viraptor
force-pushed
the
bump-archivebox-2
branch
from
07f5bd3 to
db0c2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bump archivebox.
Add two optional node runtime deps.
Add deps in PATH which are recomended at each startup.
Disable one django extensions test which is not going to be fixed anymore (upstream is working on migration to a modern version)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.