Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu-editor: init at 1.1.0-alpha.2 #277443

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rookeur
Copy link
Contributor

@Rookeur Rookeur commented Dec 29, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

package request: #73975


Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 29, 2023
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/editors/mu/default.nix Outdated Show resolved Hide resolved
@Rookeur Rookeur force-pushed the program-init-mu-editor branch from c4ebb1c to b8e00e5 Compare December 29, 2023 16:24
@Rookeur Rookeur changed the title Program init mu editor mu-editor: init at 1.1.0-alpha.2 Dec 29, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3165

@Rookeur Rookeur force-pushed the program-init-mu-editor branch from b8e00e5 to d0a89c3 Compare December 31, 2023 12:15
@Janik-Haag Janik-Haag removed their request for review December 31, 2023 12:25
pkgs/development/python-modules/pgzero/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pgzero/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pgzero/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nudatus/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nudatus/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/mu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/mu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/mu/default.nix Outdated Show resolved Hide resolved
@piegamesde piegamesde removed their request for review January 1, 2024 22:45
@Rookeur Rookeur force-pushed the program-init-mu-editor branch from d0a89c3 to 81300ac Compare January 1, 2024 23:55
@Rookeur Rookeur force-pushed the program-init-mu-editor branch from 81300ac to f76207c Compare January 3, 2024 15:21
@piegamesde piegamesde removed their request for review January 4, 2024 10:51
pkgs/development/python-modules/nudatus/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/mu/default.nix Outdated Show resolved Hide resolved
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 8, 2024
@Rookeur Rookeur force-pushed the program-init-mu-editor branch 2 times, most recently from 662e1fe to 40646bf Compare January 13, 2024 12:29
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 15, 2024
@Rookeur Rookeur requested a review from piegamesde January 20, 2024 01:56
@Rookeur Rookeur force-pushed the program-init-mu-editor branch from 40646bf to 2efa525 Compare March 4, 2024 19:42
@@ -10165,6 +10165,8 @@ with pkgs;

mtail = callPackage ../servers/monitoring/mtail { };

mu-editor = libsForQt5.callPackage ../applications/editors/mu { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried without libsForQt5? So it can be placed under by-name hierarchy?

@Rookeur Rookeur force-pushed the program-init-mu-editor branch 2 times, most recently from 9c1a4d7 to 85be6e5 Compare March 6, 2024 21:56
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Mar 6, 2024
@Rookeur Rookeur force-pushed the program-init-mu-editor branch from 85be6e5 to b44a03e Compare March 6, 2024 22:00
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Mar 6, 2024
@@ -10154,6 +10154,8 @@ with pkgs;

mtail = callPackage ../servers/monitoring/mtail { };

mu-editor = libsForQt5.callPackage ../applications/editors/mu { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mu-editor = libsForQt5.callPackage ../applications/editors/mu { };
mu-editor = callPackage ../applications/editors/mu { };


nativeBuildInputs = [
setuptools
wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need wheel? I don't think it is actually required


nativeBuildInputs = [
setuptools
wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here


nativeBuildInputs = [
py.pkgs.setuptools
py.pkgs.wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants