-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mu-editor: init at 1.1.0-alpha.2 #277443
base: master
Are you sure you want to change the base?
mu-editor: init at 1.1.0-alpha.2 #277443
Conversation
c4ebb1c
to
b8e00e5
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3165 |
b8e00e5
to
d0a89c3
Compare
d0a89c3
to
81300ac
Compare
81300ac
to
f76207c
Compare
662e1fe
to
40646bf
Compare
40646bf
to
2efa525
Compare
pkgs/top-level/all-packages.nix
Outdated
@@ -10165,6 +10165,8 @@ with pkgs; | |||
|
|||
mtail = callPackage ../servers/monitoring/mtail { }; | |||
|
|||
mu-editor = libsForQt5.callPackage ../applications/editors/mu { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried without libsForQt5
? So it can be placed under by-name hierarchy?
9c1a4d7
to
85be6e5
Compare
85be6e5
to
b44a03e
Compare
@@ -10154,6 +10154,8 @@ with pkgs; | |||
|
|||
mtail = callPackage ../servers/monitoring/mtail { }; | |||
|
|||
mu-editor = libsForQt5.callPackage ../applications/editors/mu { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mu-editor = libsForQt5.callPackage ../applications/editors/mu { }; | |
mu-editor = callPackage ../applications/editors/mu { }; |
|
||
nativeBuildInputs = [ | ||
setuptools | ||
wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need wheel? I don't think it is actually required
|
||
nativeBuildInputs = [ | ||
setuptools | ||
wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
|
||
nativeBuildInputs = [ | ||
py.pkgs.setuptools | ||
py.pkgs.wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Description of changes
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)package request: #73975
Add a 👍 reaction to pull requests you find important.