Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdpmake: init at 1.4.1 #276732

Merged
merged 2 commits into from
Mar 15, 2024
Merged

pdpmake: init at 1.4.1 #276732

merged 2 commits into from
Mar 15, 2024

Conversation

eownerdead
Copy link
Contributor

@eownerdead eownerdead commented Dec 25, 2023 •
edited
Loading

Description of changes

Add pdpmake, a public domain POSIX make.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 25, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 25, 2023
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 30, 2023
@onemoresuza
Copy link
Contributor

Reviewed points

Result of nixpkgs-review pr 276732 run on x86_64-linux 1

1 package built:
  • pdpmake
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package builds on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
    • Set meta.platforms = lib.platforms.all while maintaining the already set
      meta.badPlatforms --- see here
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • the list of phases is not overridden
  • when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.
    • N/A: No phase is overridden
  • patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
    • N/A: No patch is applied
  • patches that are remotely available are fetched rather than vendored
    • N/A: No patch is applied

Possible improvements

  1. Your addition to the maintainers list should go on a separate commit before
    adding the package. Split the commit into two.
  2. Change the license from publicDomain to unlicense.
  3. Set meta.platforms to platforms.all.

Good job on your first contribution!, @eownerdead.

onemoresuza
onemoresuza suggested changes Dec 31, 2023
View reviewed changes
pkgs/by-name/pd/pdpmake/package.nix Show resolved Hide resolved
pkgs/by-name/pd/pdpmake/package.nix Outdated Show resolved Hide resolved
piegamesde
piegamesde previously requested changes Dec 31, 2023
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
@piegamesde piegamesde removed the request for review from Janik-Haag December 31, 2023 12:05
@onemoresuza
Copy link
Contributor

Result of nixpkgs-review pr 276732 run on x86_64-linux 1

1 package built:
  • pdpmake

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 31, 2023
@eownerdead
Copy link
Contributor Author

Thanks for the kind reviews and help!
And a happy new year!

@eownerdead eownerdead mentioned this pull request Jan 31, 2024
Closed
13 tasks
pbsds
pbsds approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 276732 run on x86_64-linux 1

1 package built:
  • pdpmake

@pbsds pbsds merged commit 3d676bb into NixOS:master Mar 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelFangel MikaelFangel MikaelFangel left review comments

@onemoresuza onemoresuza onemoresuza approved these changes

@pbsds pbsds pbsds approved these changes

@piegamesde piegamesde Awaiting requested review from piegamesde

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eownerdead @onemoresuza @pbsds @piegamesde @MikaelFangel @delroth @NixOSInfra