nixos/top-level: pass activation scripts as files to avoid "Argument list too long" error #274765
+8
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops Bash from complaining "Argument list too long" due to very large activation scripts. Related: ryantm/agenix#227.
Description of changes
This PR updates the activatable system derivation to pass
activationScript
anddryActivationScripts
via files rather than via environment variables. Activation scripts are liable to grow large enough to make Bash/Linux complain about illegally large argument lists; see the above-linkedagenix
issue for one such example.Incidental change: move the
passAsFile
definition, previously in the body of thebaseSystem
system derivation definition, intosystem.systemBuilderArgs
, making it possible to extend it with[ "activationScript" "dryActivationScript" ]
elsewhere.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.