Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/top-level: pass activation scripts as files to avoid "Argument list too long" error #274765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomeon
Copy link
Contributor

@tomeon tomeon commented Dec 16, 2023

This stops Bash from complaining "Argument list too long" due to very large activation scripts. Related: ryantm/agenix#227.

Description of changes

This PR updates the activatable system derivation to pass activationScript and dryActivationScripts via files rather than via environment variables. Activation scripts are liable to grow large enough to make Bash/Linux complain about illegally large argument lists; see the above-linked agenix issue for one such example.

Incidental change: move the passAsFile definition, previously in the body of the baseSystem system derivation definition, into system.systemBuilderArgs, making it possible to extend it with [ "activationScript" "dryActivationScript" ] elsewhere.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

to stop Bash from complaining "Argument list too long" due to very large
activation scripts.
@tomeon tomeon requested a review from dasJ as a code owner December 16, 2023 17:05
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 16, 2023
@tomeon
Copy link
Contributor Author

tomeon commented Dec 16, 2023

Cargo-culting some OfBorg stuff from a recent-ish PR touching the same areas...:

@ofborg test switchTest
@ofborg test simple
@ofborg test nixos-rebuild-specialisations

@tomeon tomeon changed the title nixos/top-level: pass activation scripts as files nixos/top-level: pass activation scripts as files to avoid "Argument list too long" error Dec 16, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants