draupnir: init at 2.0.0-beta.6

[TheArcaneBrony]

Description of changes

NOTE: This PR is a successor of #222939. The previous PR was closed by accident during a rebase operation.

Original description:

Draupnir is a hardfork of Mjolnir. Mjolnir package has been unmaintained due to upstream bugs. This package is mostly a drop-in replacement. This package also uses newer methods of handling dependencies.

Repository can be found at:
https://github.com/the-draupnir-project/Draupnir

Note on testing: package and module were (and still are) tested in our production environment, works fine as far as it's been used.
Note on replacing Mjolnir: Not sure whether this is appropriate, due to general usage of the bot changing. You can however fully automatically migrate from mjolnir to draupnir.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[gaykitty]

Result of nixpkgs-review pr 274052 run on x86_64-linux 1

2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

1 package built:

• draupnir

[mweinelt]

I see a lot of potential to improve the module and to bring it in line with today's standards.

I can see that it is a copy of the mjolnir module, but I'm not willing to accept a new module of similar quality, because it is hard to maintain.

This is especially relevant with RFC42 (settings & formatters) in mind

[TheArcaneBrony]

Time for the almighty rebase on nixos:master... Please don't close the PR again...

[TheArcaneBrony]

🎊 It didn't close as merged!

[TheArcaneBrony]

(Renamed the package init commit)

[TheArcaneBrony]

(^ master rebase)

[Scrumplex]

Is there anything special here, that nix-update-script couldn't handle? It can also deal with updating the Yarn cache hash in the derivation.

Suggested change

	updateScript = ./update.sh;
	updateScript = nix-update-script { };

[TheArcaneBrony]

Hashes are stored in a separate file, I think the reason was that nix-update-script couldn't handle the Yarn cache hash? I'd have to test this once a new Draupnir version comes out.

[TheArcaneBrony]

(^ squashed in order to rebase)

[FliegendeWurst]

Darwin build fails, please mark as broken or fix:

       > gyp ERR! stack at ChildProcess.<anonymous> (/nix/store/m1ymz3alwqc71yrmzl8sas2m8ksqhhsh-nodejs-20.18.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
       > gyp ERR! System Darwin 22.2.0
       > gyp ERR! command "/nix/store/m1ymz3alwqc71yrmzl8sas2m8ksqhhsh-nodejs-20.18.0/bin/node" "/nix/store/m1ymz3alwqc71yrmzl8sas2m8ksqhhsh-nodejs-20.18.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
       > gyp ERR! cwd /private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3
       > gyp ERR! node -v v20.18.0
       > gyp ERR! node-gyp -v v10.1.0
       > gyp ERR! not ok

(unfortunately the useful part of the log is gone)

[Scrumplex]

gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build'
  TOUCH ba23eeee118cd63e16015df367567cb043fed872.intermediate
  ACTION deps_sqlite3_gyp_locate_sqlite3_target_copy_builtin_sqlite3 ba23eeee118cd63e16015df367567cb043fed872.intermediate
  TOUCH Release/obj.target/deps/locate_sqlite3.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite3/sqlite3.o
  LIBTOOL-STATIC Release/sqlite3.a
Traceback (most recent call last):
  File "/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build/gyp-mac-tool", line 772, in <module>
    sys.exit(main(sys.argv[1:]))
             ^^^^^^^^^^^^^^^^^^
  File "/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build/gyp-mac-tool", line 29, in main
    exit_code = executor.Dispatch(args)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build/gyp-mac-tool", line 44, in Dispatch
    return getattr(self, method)(*args[1:])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build/gyp-mac-tool", line 278, in ExecFilterLibtool
    libtoolout = subprocess.Popen(cmd_list, stderr=subprocess.PIPE, env=env)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/2djmffykchgm4q4j7ylv7xgkg441mp2j-python3-3.12.7/lib/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/2djmffykchgm4q4j7ylv7xgkg441mp2j-python3-3.12.7/lib/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'libtool'
make: *** [deps/sqlite3.target.mk:242: Release/sqlite3.a] Error 1
rm ba23eeee118cd63e16015df367567cb043fed872.intermediate
make: Leaving directory '/private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.<anonymous> (/nix/store/n3yy2py144i01235yqq6ps3ah5dkynx2-nodejs-20.18.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
gyp ERR! System Darwin 24.0.0
gyp ERR! command "/nix/store/n3yy2py144i01235yqq6ps3ah5dkynx2-nodejs-20.18.0/bin/node" "/nix/store/n3yy2py144i01235yqq6ps3ah5dkynx2-nodejs-20.18.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /private/tmp/nix-build-draupnir-modules-2.0.0-beta.8.drv-0/node_modules/better-sqlite3
gyp ERR! node -v v20.18.0
gyp ERR! node-gyp -v v10.1.0
gyp ERR! not ok 

After adding libtool to nativeBuildInputs of better-sqlite3 it failed with a different error saying that -static is an unrecognized parameter. It seems like -static only exists in Apple's toolchain? nodejs/node#2341

[FliegendeWurst]

CI says

Identifiers present in the source must have a mapping in the redirects file.
    - module-services-draupnir
    - module-services-draupnir-setup
    - module-services-draupnir-matrix-synapse-antispam
    - module-services-draupnir-setup-ems

Check nixos/doc/manual/redirects.json

[TheArcaneBrony]

@FliegendeWurst uncertain what redirects are or why I need them? There's nothing to redirect from?

[FliegendeWurst]

I think you just need to add

"module-services-draupnir": [
  "index.html#module-services-draupnir"
]

for each of the IDs listed above. The "redirect" doesn't do much here but it will be useful if the module ever gets removed or renamed, or the manual finally gets split into multiple pages.