cudaPackages.cudatoolkit: fix the setupCudaHook not being propagated correctly #273048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix the incompatible gcc error by adding cuda_nvcc to nativeBuildInputs (cudaPackages.cudatoolkit in buildInputs is insufficient because that doesn't propagate the hook)
ofborg
bot
added
11.by: package-maintainer
blurgyy
added a commit
to blurgyy/flames
that referenced
this pull request
Dec 11, 2023
Waiting for <NixOS/nixpkgs#273048> Signed-off-by: Gaoyang Zhang <[email protected]>
|
ConnorBaker
approved these changes
Dec 11, 2023
ConnorBaker
added
backport release-23.11
6.topic: cuda
|
Looks good to me, merging. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-273048-to-release-23.11 origin/release-23.11
cd .worktree/backport-273048-to-release-23.11
git switch --create backport-273048-to-release-23.11
git cherry-pick -x 810599277409a7d564c159983f3bb4a51aed1ea3 7c97d5f5c441cce6ad717a85676eec7c7ff1b27e |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Missed in #271078. Here's an example of a related error: https://hercules-ci.com/accounts/github/SomeoneSerge/derivations/%2Fnix%2Fstore%2F064plchffmjm075mhb0m3s00q3977hpl-suitesparse-5.13.0.drv/log?via-job=0a87e961-e83f-43e5-89fd-0fa01863101b
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.