Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasmahud: fix runtime errors and other cleanup #271479

Merged
merged 7 commits into from
Apr 17, 2024
Merged

plasmahud: fix runtime errors and other cleanup #271479

merged 7 commits into from
Apr 17, 2024

Conversation

eclairevoyant
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@eclairevoyant
Copy link
Contributor Author

@asd-noor Can you check if this works now? I no longer see the error, but not sure how to test this if it's actually working either.

@ofborg ofborg bot requested a review from pasqui23 December 2, 2023 00:28
nbraud
nbraud requested changes Dec 12, 2023
View reviewed changes
pkgs/misc/plasma-hud/default.nix Show resolved Hide resolved
pkgs/misc/plasma-hud/default.nix Show resolved Hide resolved
nbraud
nbraud approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@nbraud nbraud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing the multiple commits the first time around 😓

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 13, 2023
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 8, 2024
@superherointj superherointj merged commit 4dcd08c into NixOS:master Apr 17, 2024
23 checks passed
@eclairevoyant eclairevoyant deleted the plasmahud branch April 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

@nbraud nbraud nbraud approved these changes

@pasqui23 pasqui23 Awaiting requested review from pasqui23

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlasmaHUD not working (missing Gtk namespace)
5 participants
@eclairevoyant @nbraud @superherointj @delroth @wegank