Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mysql-auth: fix passwords in config files #271441

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

NetaliDev
Copy link
Member

Description of changes

The script to append the passwords to the MySQL-Auth configuration files got broken in #263203 by commit b5617e0. This PR fixes this by moving the script to a separate systemd oneshot. It also adds me as a maintainer for the module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 1, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 1, 2023
@NetaliDev NetaliDev requested a review from Janik-Haag December 1, 2023 22:13
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, would you mind updating the nixosTests.auth-mysql, which currently fails on master and in this pr?

@NetaliDev
Copy link
Member Author

Fixed

@NetaliDev
Copy link
Member Author

@ofborg test auth-mysql

@NetaliDev
Copy link
Member Author

Also added the test to the related packages.

@NetaliDev
Copy link
Member Author

@ofborg build libnss-mysql pam_mysql

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 2, 2023
@Janik-Haag Janik-Haag merged commit c3ac6b9 into NixOS:master Dec 2, 2023
25 of 28 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2023

Successfully created backport PR for release-23.11:

@NetaliDev NetaliDev deleted the mysql-auth-fix branch December 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants