Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{libqalculate, qalculate-gtk, qalculate-qt}: 4.8.1 -> 4.9.0 #271142

Merged
merged 3 commits into from
Dec 10, 2023

Conversation

alyaeanyx
Copy link
Member

@alyaeanyx alyaeanyx commented Nov 30, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

@alyaeanyx also gtk and qt derivations are missing meta.mainProgram

@alyaeanyx
Copy link
Member Author

Done!

Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 271142 run on x86_64-linux 1

56 packages built:
  • albert
  • breath-theme
  • cantor
  • colloid-kde
  • graphite-kde-theme
  • labplot
  • latte-dock
  • layan-kde
  • libqalculate
  • libqalculate.dev
  • libqalculate.doc
  • libsForQt5.applet-window-appmenu
  • libsForQt5.bismuth
  • libsForQt5.kde-cli-tools
  • libsForQt5.kdeplasma-addons
  • libsForQt5.kdev-php
  • libsForQt5.kdev-python
  • libsForQt5.kdevelop
  • libsForQt5.kdevelop-unwrapped
  • libsForQt5.khotkeys
  • libsForQt5.khotkeys.bin
  • libsForQt5.khotkeys.dev
  • libsForQt5.kinfocenter
  • libsForQt5.kmenuedit
  • libsForQt5.krohnkite
  • libsForQt5.kwin-dynamic-workspaces
  • libsForQt5.kwin-tiling
  • libsForQt5.kzones
  • libsForQt5.parachute
  • libsForQt5.plasma-bigscreen
  • libsForQt5.plasma-browser-integration
  • libsForQt5.plasma-desktop
  • libsForQt5.plasma-disks
  • libsForQt5.plasma-disks.bin
  • libsForQt5.plasma-disks.dev
  • libsForQt5.plasma-mobile
  • libsForQt5.plasma-remotecontrollers
  • libsForQt5.plasma-workspace
  • libsForQt5.plasma-workspace.dev
  • libsForQt5.powerdevil
  • libsForQt5.systemsettings
  • libsForQt5.systemsettings.bin
  • libsForQt5.systemsettings.dev
  • libsForQt5.xdg-desktop-portal-kde
  • lightly-boehs
  • lightly-qt
  • nordic
  • nordic.sddm
  • pop-launcher
  • qalculate-gtk
  • qalculate-qt
  • qogir-kde
  • rofi-calc
  • utterly-nord-plasma
  • wacomtablet
  • whitesur-kde

@kirillrdy
Copy link
Member

obforg eval error happens to other PRs

@kirillrdy
Copy link
Member

Result of nixpkgs-review pr 271142 run on aarch64-linux 1

56 packages built:
  • albert
  • breath-theme
  • cantor
  • colloid-kde
  • graphite-kde-theme
  • labplot
  • latte-dock
  • layan-kde
  • libqalculate
  • libqalculate.dev
  • libqalculate.doc
  • libsForQt5.applet-window-appmenu
  • libsForQt5.bismuth
  • libsForQt5.kde-cli-tools
  • libsForQt5.kdeplasma-addons
  • libsForQt5.kdev-php
  • libsForQt5.kdev-python
  • libsForQt5.kdevelop
  • libsForQt5.kdevelop-unwrapped
  • libsForQt5.khotkeys
  • libsForQt5.khotkeys.bin
  • libsForQt5.khotkeys.dev
  • libsForQt5.kinfocenter
  • libsForQt5.kmenuedit
  • libsForQt5.krohnkite
  • libsForQt5.kwin-dynamic-workspaces
  • libsForQt5.kwin-tiling
  • libsForQt5.kzones
  • libsForQt5.parachute
  • libsForQt5.plasma-bigscreen
  • libsForQt5.plasma-browser-integration
  • libsForQt5.plasma-desktop
  • libsForQt5.plasma-disks
  • libsForQt5.plasma-disks.bin
  • libsForQt5.plasma-disks.dev
  • libsForQt5.plasma-mobile
  • libsForQt5.plasma-remotecontrollers
  • libsForQt5.plasma-workspace
  • libsForQt5.plasma-workspace.dev
  • libsForQt5.powerdevil
  • libsForQt5.systemsettings
  • libsForQt5.systemsettings.bin
  • libsForQt5.systemsettings.dev
  • libsForQt5.xdg-desktop-portal-kde
  • lightly-boehs
  • lightly-qt
  • nordic
  • nordic.sddm
  • pop-launcher
  • qalculate-gtk
  • qalculate-qt
  • qogir-kde
  • rofi-calc
  • utterly-nord-plasma
  • wacomtablet
  • whitesur-kde

@doronbehar
Copy link
Contributor

@ofborg eval

@doronbehar
Copy link
Contributor

@GrahamcOfBorg eval

@doronbehar
Copy link
Contributor

OK I'll take the almost empty risk of merging without waiting for ofborg - changes seem trivial after all and I can't trigger it.

@doronbehar doronbehar merged commit 29d6c96 into NixOS:master Dec 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants