Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed_dreams: remove override libpng #270194

Closed
wants to merge 1 commit into from
Closed

speed_dreams: remove override libpng #270194

wants to merge 1 commit into from

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

#259879

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey requested a review from siraben November 26, 2023 16:53
@Stunkymonkey Stunkymonkey mentioned this pull request Nov 26, 2023
Closed
9 tasks
@Stunkymonkey Stunkymonkey force-pushed the speed_dreams-remove-override-libpng branch from 62ac5d7 to 85bf80d Compare November 26, 2023 21:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 27, 2023
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 270194 run on x86_64-linux 1

@Stunkymonkey Stunkymonkey force-pushed the speed_dreams-remove-override-libpng branch from 85bf80d to 90e9b70 Compare January 1, 2024 19:42
@Artturin Artturin closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben Awaiting requested review from siraben

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @Artturin