tetex: remove override libpng

[Stunkymonkey]

Description of changes

#259879

with libpng it does not compile.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

Not in accordance with by-name README.md

[Stunkymonkey]

@pbsds so moving the default.nix to pkgs/by-name/te/tetex/package.nix would be the additional change?

[pbsds]

I'm not blocking, but in #259879 we found that the override should be kept, not inlined.

[Stunkymonkey]

I'm not blocking, but in #259879 we found that the override should be kept, not inlined.

I am reading: If the override is still necessary then move it directly to the default.nix with a comment about why.

[pbsds]

And in that thread I and kirilldry challenge the issue, since the by-name README states that using libpng12 as input instead of libpng changes the override interface and is therefore discouraged.

[pbsds]

error: builder for '/nix/store/hapr60a6qhjwd2hhf5ljz2334pmfp5ll-tetex-3.0.drv' failed with exit code 2;
       last 10 log lines:
       > writepng.c:152:45: error: invalid use of incomplete typedef 'png_info' {aka 'struct png_info_def'}
       >   152 |             pdfbuf[pdfptr++] = png_info(img)->palette[i].blue;
       >       |                                             ^~

The issue is explained here #259879 (comment)