python311Packages.scs: fix build; 3.2.3 -> 3.2.4 #268178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
|
Annoying that they don't use pkg-config for that. |
|
cc @renesat given past changes |
ghost
marked this pull request as ready for review
yeah -- i don't know meson well, but changing cc.find_library -> dependency and adding pkg-config works well on linux -- no env vars needed. |
|
That might be a good thing to propose upstream, if you're interested. |
ghost
mentioned this pull request
proposed -- doesn't work with their CI for some reason. I was hoping dependency would fall back to find_library, but it doesn't seem to. |
ghost
changed the title
mweinelt
reviewed
Nov 19, 2023
added 3 commits
November 19, 2023 00:11
after numpy updated to 1.26.1 distutils no longer provides the lib locations so use env vars for non-darwin. On darwin Accelerate library is prioritized over BLAS so add Accelerate to buildInputs.
|
Awesome work! |
ghost
added
the
0.kind: ZHF Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy change 1.25.1 -> 1.26.1 237a590 moved away from distutils and the scs build was unable to locate the blas and lapack libs and failed.
this change fixes the build by adding env vars so the build can locate the blas lapack libs for linux and the Accelerate lib for darwin. scs is then updated to 3.2.4. incorporates upstream PR bodono/scs-python#78 to use pkg-config and add myself as maintainer so i can remove the patches on the next version update.
Note that the linear algebra library for darwin is Accelerate as that is prioritized over blas / lapack by the build.
https://hydra.nixos.org/build/241138404
ZHF: #265948
bambi failures due to numpy < 1.26 constraints in pytensor
Result of
nixpkgs-reviewrun on x86_64-linux 128 packages marked as broken and skipped:
4 packages failed to build:
24 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)