Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/postgresql: document psql 15 changes #267238

Merged
merged 7 commits into from
Nov 17, 2023
Merged

nixos/postgresql: document psql 15 changes #267238

merged 7 commits into from
Nov 17, 2023

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Nov 13, 2023

Description of changes

Update manual for postgres 15 changes.

see #216989 #266270

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 13, 2023
@bendlas bendlas requested a review from Ma27 November 13, 2023 15:38
RaitoBezarius
RaitoBezarius reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thank you so much for writing this!

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 13, 2023
@bendlas
Copy link
Contributor Author

bendlas commented Nov 14, 2023

ref #216989
ref #203474
ref #255961

cc @exzombie @rycee @Scrumplex would you mind fact checking the manual update? I'm still not super familiar with the issue

@bendlas bendlas requested review from rycee and Scrumplex November 14, 2023 01:40
@bendlas
Copy link
Contributor Author

bendlas commented Nov 17, 2023

Branch - off in 3 days, so last chance to review this ...

@RaitoBezarius
Copy link
Member

Can you squash all the history?

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2023
@bendlas bendlas merged commit e7c7d97 into NixOS:master Nov 17, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@rycee rycee Awaiting requested review from rycee

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bendlas @RaitoBezarius @delroth