Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin-utils: fix build with clang 16 #266589

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 10, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Nov 10, 2023

Result of nixpkgs-review pr 266589 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • bonmin
2 packages failed to build:
  • haskellPackages.coinor-clp
  • haskellPackages.coinor-clp.doc
3 packages built:
  • clp
  • fast-downward
  • osi

@wegank
Copy link
Member Author

wegank commented Nov 10, 2023

I'd probably leave the Haskell failures to #266172.

@wegank wegank merged commit 34d322a into NixOS:staging-next Nov 10, 2023
24 of 25 checks passed
@wegank wegank deleted the coinutils-clang-16 branch November 10, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant