-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teller: fix build #266224
teller: fix build #266224
Conversation
add HOME=$(mktemp -d) in checkPhase
fails to build for me
|
never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux) |
my is also x86_64-linux, let me try using your commit instead of a merge |
@robert-manchester you commit indeed builds ,but merge fails ( i tried two times with same error ) rebase on master, you should get same error |
the PR is only 50 commits off master. i did pull master in and rebase and still can not reproduce the error you have above. can only reproduce the error from hydra without my change. |
can you try running |
Result of 1 package built:
|
facinating !
logically, I would think it should be
|
is passing for me now is it possible that we had a regression in those 50 commits ? |
Result of 1 package built:
|
i did not modify the PR to merge in master. there is one force push but that happened 5 min after i created the PR and I just put "" around the subshell. either you were triggering a different issue or there is something going on with your setup. either way, seems unrelated to this change. |
Description of changes
add HOME=$(mktemp -d) in checkPhase
ZHF: #265948
https://hydra.nixos.org/build/239074453
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)