Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teller: fix build #266224

Merged
merged 1 commit into from Nov 8, 2023
Merged

teller: fix build #266224

merged 1 commit into from Nov 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2023

Description of changes

add HOME=$(mktemp -d) in checkPhase

ZHF: #265948
https://hydra.nixos.org/build/239074453

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2023
add HOME=$(mktemp -d) in checkPhase
@kirillrdy
Copy link
Member

fails to build for me

$ nix build --nix-path nixpkgs=/home/kirillvr/.cache/nixpkgs-review/pr-266224/nixpkgs nixpkgs-overlays=/tmp/tmpagq3y_gq --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed -f /home/kirillvr/.cache/nixpkgs-review/pr-266224/build.nix
error: builder for '/nix/store/hrwa9lfb7ssyi0m54vg7jp5hi907kpyc-teller-1.5.6.drv' failed with exit code 2;
       last 10 log lines:
       >     --- PASS: TestE2E/Sh_print (0.01s)
       >     --- FAIL: TestE2E/scan_entries (0.01s)
       >     --- PASS: TestE2E/Put_with_--sync_flag (0.01s)
       >     --- PASS: TestE2E/Delete_multiple_entires (0.01s)
       >     --- PASS: TestE2E/yaml (0.01s)
       >     --- PASS: TestE2E/version (0.00s)
       > FAIL
       > FAIL      github.com/spectralops/teller/e2e       0.061s
       > FAIL
       > make: *** [Makefile:44: e2e] Error 1
       For full logs, run 'nix log /nix/store/hrwa9lfb7ssyi0m54vg7jp5hi907kpyc-teller-1.5.6.drv'.
error: 1 dependencies of derivation '/nix/store/81hxsw5y9sfp26023i91km865fwdgwnm-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/266224

1 package failed to build:
teller

@ghost
Copy link
Author

ghost commented Nov 8, 2023

never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux)
https://hydra.nixos.org/log/zbm3v2yyvdkzl9gyaqdb6hcggzwsh6a7-teller-1.5.6.drv

@kirillrdy
Copy link
Member

never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux) https://hydra.nixos.org/log/zbm3v2yyvdkzl9gyaqdb6hcggzwsh6a7-teller-1.5.6.drv

my is also x86_64-linux, let me try using your commit instead of a merge

@kirillrdy
Copy link
Member

never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux) https://hydra.nixos.org/log/zbm3v2yyvdkzl9gyaqdb6hcggzwsh6a7-teller-1.5.6.drv

my is also x86_64-linux, let me try using your commit instead of a merge

@robert-manchester you commit indeed builds ,but merge fails ( i tried two times with same error )

rebase on master, you should get same error

@ghost
Copy link
Author

ghost commented Nov 8, 2023

never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux) https://hydra.nixos.org/log/zbm3v2yyvdkzl9gyaqdb6hcggzwsh6a7-teller-1.5.6.drv

my is also x86_64-linux, let me try using your commit instead of a merge

@robert-manchester you commit indeed builds ,but merge fails ( i tried two times with same error )

rebase on master, you should get same error

the PR is only 50 commits off master. i did pull master in and rebase and still can not reproduce the error you have above. can only reproduce the error from hydra without my change.

@kirillrdy
Copy link
Member

never saw that failure -- just fixed the one listed in the hydra log, which was reproducible on my machine (x64 linux) https://hydra.nixos.org/log/zbm3v2yyvdkzl9gyaqdb6hcggzwsh6a7-teller-1.5.6.drv

my is also x86_64-linux, let me try using your commit instead of a merge

@robert-manchester you commit indeed builds ,but merge fails ( i tried two times with same error )
rebase on master, you should get same error

the PR is only 50 commits off master. i did pull master in and rebase and still can not reproduce the error you have above. can only reproduce the error from hydra without my change.

can you try running nixpkgs-review pr 266224 ?

@ghost
Copy link
Author

ghost commented Nov 8, 2023

nix run .\#nixpkgs-review pr 266224 -- --print-result

Result of nixpkgs-review pr 266224 run on x86_64-linux 1

1 package built:
  • teller

@kirillrdy
Copy link
Member

kirillrdy commented Nov 8, 2023

nix run .#nixpkgs-review pr 266224 -- --print-result

facinating !

nix run .\#nixpkgs-review pr 266224 -- --print-result passes for me

logically, I would think it should be

nix run .\#nixpkgs-review -- pr 266224 --print-result

@kirillrdy
Copy link
Member

@robert-manchester

nixpkgs-review pr 266224

is passing for me now

is it possible that we had a regression in those 50 commits ?

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 8, 2023
@wamserma
Copy link
Member

wamserma commented Nov 8, 2023

Result of nixpkgs-review pr 266224 run on aarch64-linux 1

1 package built:
  • teller

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 8, 2023
@ghost
Copy link
Author

ghost commented Nov 8, 2023

@robert-manchester

nixpkgs-review pr 266224

is passing for me now

is it possible that we had a regression in those 50 commits ?

i did not modify the PR to merge in master. there is one force push but that happened 5 min after i created the PR and I just put "" around the subshell. either you were triggering a different issue or there is something going on with your setup. either way, seems unrelated to this change.

@wegank wegank merged commit c0a2d9c into NixOS:master Nov 8, 2023
16 checks passed
@ghost ghost deleted the teller_fix_build branch November 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants