Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mathjax-node-cli: use buildNpmPackage #265148

Merged
merged 1 commit into from
Nov 9, 2023
Merged

mathjax-node-cli: use buildNpmPackage #265148

merged 1 commit into from
Nov 9, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

see #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from uninsane November 3, 2023 05:20
uninsane
uninsane approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied locally and working as expected. thanks for tackling this.

@uninsane uninsane added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 9, 2023
@dotlambda dotlambda merged commit ab5d876 into NixOS:master Nov 9, 2023
27 of 28 checks passed
@dotlambda dotlambda deleted the mathjax-node-cli-buildNpmPackage branch November 9, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uninsane uninsane uninsane approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @uninsane