-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nix-channel: fix subscribing to default channel #264608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing seems to confirm this is fixed, approving.
I'll wait for ofborg eval, which might take a few hours, and merge then. |
@ofborg test activation-nix-channel |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Now that the PR has been merged, I have a new symptom that I think is related. I did the fix:
So now I have:
But when I rebuild, I get this error:
|
Did you run |
@eclairevoyant Thank you; that solved the problem. Apologies for asking here instead of on Discourse. I thought since this was a known issue, it would be helpful to others to have the full fix documented here. But now that I know the solution was |
Description of changes
Fixes #264602
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)