Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smc-manjari: init at 2.200 #264540

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

adtya
Copy link
Member

@adtya adtya commented Oct 31, 2023

Description of changes

Adding the Manjari Font from Swanthanthra Malayalam Computing, https://smc.org.in/fonts/manjari

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/data/fonts/smc-manjari/default.nix Outdated Show resolved Hide resolved
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 16, 2023
@FliegendeWurst FliegendeWurst self-requested a review November 17, 2023 12:33
@FliegendeWurst FliegendeWurst removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2023
@adtya adtya force-pushed the smc/manjari/init branch 2 times, most recently from 85c10f9 to c98ec1f Compare November 24, 2023 19:02
@adtya
Copy link
Member Author

adtya commented Dec 2, 2023

@FliegendeWurst can you approve this?

@FliegendeWurst
Copy link
Member

Approved. Can't merge though (no permission).

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2023
@pbsds pbsds added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 11, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2024
@adtya adtya force-pushed the smc/manjari/init branch from e362471 to 2110cf4 Compare June 12, 2024 16:35
@pbsds
Copy link
Member

pbsds commented Jun 12, 2024

Please rebase rather than merge

@adtya adtya force-pushed the smc/manjari/init branch from 2110cf4 to 592eb56 Compare June 16, 2024 12:50
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 26, 2024
@FliegendeWurst
Copy link
Member

Fixed commit message and formatted with nixfmt-rfc-style.

@FliegendeWurst FliegendeWurst merged commit c239bf4 into NixOS:master Dec 15, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants