Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/activation: remove specialfs activationScript" #264200

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Revert "nixos/activation: remove specialfs activationScript" #264200

merged 1 commit into from
Oct 29, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Oct 29, 2023 •
edited
Loading

This reverts commit a8f50f9.

Broke installer tests, need to figure out how to fix nixos-enter before attempting this again.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900
Revert "nixos/activation: remove specialfs activationScript"
7ea67d7 
This reverts commit a8f50f9.

Broke installer tests, need to figure out how to fix nixos-enter before attempting this again.
@K900 K900 requested a review from dasJ as a code owner October 29, 2023 17:16
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 29, 2023
@K900 K900 added the 1.severity: blocker This is preventing another PR or issue from being completed label Oct 29, 2023
@K900 K900 mentioned this pull request Oct 29, 2023
Merged
13 tasks
@K900 K900 merged commit b9d8a73 into NixOS:master Oct 29, 2023
10 checks passed
@adamcstephens adamcstephens mentioned this pull request Oct 30, 2023
Closed
13 tasks
@nikstur nikstur mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
1.severity: blocker This is preventing another PR or issue from being completed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@K900